remove tls.ini loading and is_no_tls_host to net_utils #1690

Merged
merged 3 commits into from Oct 25, 2016

Conversation

Projects
None yet
2 participants
@msimerson
Member

msimerson commented Oct 25, 2016

Changes proposed in this pull request:

  • move tls_socket.load_tls_ini() loading to net_utils.load_tls_ini()
  • replace tls_socket.is_no_tls_host() with more abstract net_utils.ip_in_list()
  • refactors outbound tls.ini loading into new function outbound.get_tls_options()
    • with test coverage
    • adds missing dhparam file loading

Checklist:

  • docs updated
  • tests updated

msimerson added some commits Oct 18, 2016

remove no-tls-hosts and tls.ini loading to net-utils
* update smtp_forward for wildcard boolean no init
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 25, 2016

Current coverage is 36.09% (diff: 74.28%)

Merging #1690 into master will increase coverage by 0.09%

@@             master      #1690   diff @@
==========================================
  Files            24         24          
  Lines          6064       6059     -5   
  Methods         782        781     -1   
  Messages          0          0          
  Branches       1536       1533     -3   
==========================================
+ Hits           2183       2187     +4   
+ Misses         3881       3872     -9   
  Partials          0          0          

Powered by Codecov. Last update aa6d42e...f016cf0

codecov-io commented Oct 25, 2016

Current coverage is 36.09% (diff: 74.28%)

Merging #1690 into master will increase coverage by 0.09%

@@             master      #1690   diff @@
==========================================
  Files            24         24          
  Lines          6064       6059     -5   
  Methods         782        781     -1   
  Messages          0          0          
  Branches       1536       1533     -3   
==========================================
+ Hits           2183       2187     +4   
+ Misses         3881       3872     -9   
  Partials          0          0          

Powered by Codecov. Last update aa6d42e...f016cf0

@msimerson msimerson added the Bug Fix label Oct 25, 2016

@msimerson msimerson merged commit 6fc4006 into haraka:master Oct 25, 2016

3 checks passed

codecov/patch 74.28% of diff hit (target 35.99%)
Details
codecov/project 36.09% (+0.09%) compared to aa6d42e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson deleted the msimerson:reduce-tls-socket branch Oct 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment