New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haraka/Haraka#1690 fix outbound to avoid recursive reading key/cert after refactoring #1692

Merged
merged 1 commit into from Oct 26, 2016

Conversation

Projects
None yet
3 participants
@typingArtist
Collaborator

typingArtist commented Oct 26, 2016

Fixes #1690

I’m getting TypeError: Path must be a string. as reported by others. The attached PR fixes the bug introduced by refactoring in #1690, with that change we don’t need to read the key inside the STARTTLS routine because it was already loaded.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 26, 2016

Current coverage is 36.13% (diff: 100%)

Merging #1692 into master will increase coverage by 0.03%

@@             master      #1692   diff @@
==========================================
  Files            24         24          
  Lines          6059       6053     -6   
  Methods         781        781          
  Messages          0          0          
  Branches       1533       1531     -2   
==========================================
  Hits           2187       2187          
+ Misses         3872       3866     -6   
  Partials          0          0          

Powered by Codecov. Last update 6fc4006...352b226

codecov-io commented Oct 26, 2016

Current coverage is 36.13% (diff: 100%)

Merging #1692 into master will increase coverage by 0.03%

@@             master      #1692   diff @@
==========================================
  Files            24         24          
  Lines          6059       6053     -6   
  Methods         781        781          
  Messages          0          0          
  Branches       1533       1531     -2   
==========================================
  Hits           2187       2187          
+ Misses         3872       3866     -6   
  Partials          0          0          

Powered by Codecov. Last update 6fc4006...352b226

@msimerson msimerson merged commit 12044a4 into haraka:master Oct 26, 2016

3 checks passed

codecov/patch Coverage not affected when comparing 6fc4006...352b226
Details
codecov/project 36.13% (+0.03%) compared to 6fc4006
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@msimerson

This comment has been minimized.

Show comment
Hide comment
@msimerson

msimerson Oct 26, 2016

Member

I swear I removed that. I must have buggered it later when rebasing. Thanks for fixing it.

Member

msimerson commented Oct 26, 2016

I swear I removed that. I must have buggered it later when rebasing. Thanks for fixing it.

@msimerson msimerson added the Bug Fix label Oct 26, 2016

@msimerson msimerson self-assigned this Oct 26, 2016

@typingArtist typingArtist deleted the typingArtist:fix_outbound_key branch Oct 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment