auth/vpopmail: do not toString() when null #1695

Merged
merged 3 commits into from Nov 8, 2016

Conversation

Projects
None yet
2 participants
@msimerson
Member

msimerson commented Nov 8, 2016

  • do not toString() when null
    • avoids a CRIT error when plain_pass is null/undefined.
  • reduce log severity of failed pass
  • lint fixes (whitespace)

@msimerson msimerson added the Bug Fix label Nov 8, 2016

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 8, 2016

Current coverage is 36.13% (diff: 40.00%)

Merging #1695 into master will not change coverage

@@             master      #1695   diff @@
==========================================
  Files            24         24          
  Lines          6053       6053          
  Methods         781        781          
  Messages          0          0          
  Branches       1531       1531          
==========================================
  Hits           2187       2187          
  Misses         3866       3866          
  Partials          0          0          

Powered by Codecov. Last update 12044a4...b1cf00e

codecov-io commented Nov 8, 2016

Current coverage is 36.13% (diff: 40.00%)

Merging #1695 into master will not change coverage

@@             master      #1695   diff @@
==========================================
  Files            24         24          
  Lines          6053       6053          
  Methods         781        781          
  Messages          0          0          
  Branches       1531       1531          
==========================================
  Hits           2187       2187          
  Misses         3866       3866          
  Partials          0          0          

Powered by Codecov. Last update 12044a4...b1cf00e

@msimerson msimerson changed the title from do not toString() when undefined to auth/vpopmail: do not toString() when null Nov 8, 2016

@msimerson msimerson merged commit bd94d89 into haraka:master Nov 8, 2016

3 checks passed

codecov/patch 40.00% of diff hit (target 36.13%)
Details
codecov/project 36.13% (+0.00%) compared to 12044a4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson deleted the msimerson:auth_vpopmail-crit branch Nov 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment