New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc dkim_sign updates #1707

merged 1 commit into from Nov 13, 2016


None yet
2 participants

msimerson commented Nov 13, 2016

Fixes #1705
closes #1706

Changes proposed in this pull request:

  • use path.* instead of / delimited string (cross-platform compat)
  • set haraka_dir to empty string when process.env.HARAKA is unset (for testing)
  • switch from fs.exists (deprecated) to fs.stat for directory detection
  • switch from async.filter to async.detectSeries (b/c results order matters)
  • improved test coverage for get_key_dir


  • docs updated
  • tests updated

@msimerson msimerson added the Bug Fix label Nov 13, 2016

@smfreegard smfreegard referenced this pull request Nov 13, 2016


Fixes #1705 #1706

@smfreegard smfreegard merged commit 9fa2f56 into haraka:master Nov 13, 2016

3 checks passed

codecov/patch Coverage not affected when comparing 0c95c02...a56e610
codecov/project 36.13% (+0.00%) compared to 0c95c02
continuous-integration/travis-ci/pr The Travis CI build passed

@msimerson msimerson deleted the msimerson:dkim-sign branch Nov 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment