remove utils.uniq() #1718
Closed
remove utils.uniq() #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is not used anywhere & implementation is poor. It only works if the array provided is ordered
Current coverage is 36.15% (diff: 100%)@@ master #1718 diff @@
==========================================
Files 24 24
Lines 6059 6049 -10
Methods 781 780 -1
Messages 0 0
Branches 1532 1530 -2
==========================================
- Hits 2188 2187 -1
+ Misses 3871 3862 -9
Partials 0 0
|
|
this PR obsoleted by #1720 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
(discovered while adding test coverage)