New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ./utils with npm packaged haraka-utils #1720

Merged
merged 1 commit into from Nov 17, 2016

Conversation

Projects
None yet
2 participants
@msimerson
Member

msimerson commented Nov 15, 2016

Changes proposed in this pull request:

  • replace ./utils with npm packaged haraka-utils
  • replace utils.existsSync with fs.existsSync (node 0.8 anachronism)
  • replace a couple more "string / string" paths with path.join()

Checklist:

  • docs updated
  • tests updated
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 15, 2016

Current coverage is 34.47% (diff: 64.86%)

Merging #1720 into master will decrease coverage by 1.63%

@@             master      #1720   diff @@
==========================================
  Files            24         23     -1   
  Lines          6059       5883   -176   
  Methods         781        755    -26   
  Messages          0          0          
  Branches       1532       1498    -34   
==========================================
- Hits           2188       2028   -160   
+ Misses         3871       3855    -16   
  Partials          0          0          

Powered by Codecov. Last update 43cd4ac...7ce4c24

codecov-io commented Nov 15, 2016

Current coverage is 34.47% (diff: 64.86%)

Merging #1720 into master will decrease coverage by 1.63%

@@             master      #1720   diff @@
==========================================
  Files            24         23     -1   
  Lines          6059       5883   -176   
  Methods         781        755    -26   
  Messages          0          0          
  Branches       1532       1498    -34   
==========================================
- Hits           2188       2028   -160   
+ Misses         3871       3855    -16   
  Partials          0          0          

Powered by Codecov. Last update 43cd4ac...7ce4c24

@msimerson msimerson merged commit 7da87e4 into haraka:master Nov 17, 2016

3 checks passed

codecov/patch 64.86% of diff hit (target 36.11%)
Details
codecov/project Absolute coverage decreased by -1.63% but relative coverage increased by +28.75% compared to 43cd4ac
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson deleted the msimerson:npm-packaged-utils branch Nov 17, 2016

@msimerson msimerson referenced this pull request Nov 17, 2016

Closed

remove utils.uniq() #1718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment