fix tls option servername (not hostname) #1728

Merged
merged 1 commit into from Nov 20, 2016

Conversation

3 participants
@typingArtist
Collaborator

typingArtist commented Nov 20, 2016

Seems I made a typo. The given hostname should be stored in servername to be recognized as the SNI hostname when acting as a SMTP client. For some reason I added the feature correctly to outbound.js but not to smtp_client.js. See here.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 20, 2016

Current coverage is 34.48% (diff: 0.00%)

Merging #1728 into master will not change coverage

@@             master      #1728   diff @@
==========================================
  Files            23         23          
  Lines          5919       5919          
  Methods         761        761          
  Messages          0          0          
  Branches       1503       1503          
==========================================
  Hits           2041       2041          
  Misses         3878       3878          
  Partials          0          0          

Powered by Codecov. Last update 9f63d07...d80de7a

codecov-io commented Nov 20, 2016

Current coverage is 34.48% (diff: 0.00%)

Merging #1728 into master will not change coverage

@@             master      #1728   diff @@
==========================================
  Files            23         23          
  Lines          5919       5919          
  Methods         761        761          
  Messages          0          0          
  Branches       1503       1503          
==========================================
  Hits           2041       2041          
  Misses         3878       3878          
  Partials          0          0          

Powered by Codecov. Last update 9f63d07...d80de7a

@msimerson msimerson merged commit 6061c62 into haraka:master Nov 20, 2016

2 of 3 checks passed

codecov/patch 0.00% of diff hit (target 34.48%)
Details
codecov/project 34.48% remains the same compared to 9f63d07
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@typingArtist typingArtist deleted the typingArtist:fix_sni_servername branch Nov 20, 2016

@msimerson msimerson added this to Done in tls-revamp Feb 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment