New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an outbound queue filename handler #1792

Merged
merged 8 commits into from Feb 6, 2017

Conversation

Projects
None yet
3 participants
@EyePulp
Collaborator

EyePulp commented Jan 31, 2017

  • Standardize on the underscore for delimiting all queue filename bits
  • Return a simple object for the parts
  • Add the original arrival timestamp to the filename
  • Calculate message "age" value when getting file parts
  • Allow for [re]names with defaults & overrides
  • Convert older filename formats in the queue during an update

@msimerson msimerson requested a review from baudehlo Jan 31, 2017

@EyePulp

You should be able to remove lines 34/35 that reference the fn_re variable as that's part my refactor.

@msimerson

This comment has been minimized.

Show comment
Hide comment
@msimerson

msimerson Feb 1, 2017

Member

Ahhh, that was me using GitHub's fancy "fix merge conflicts tool," but apparently I didn't do it very well.

Member

msimerson commented Feb 1, 2017

Ahhh, that was me using GitHub's fancy "fix merge conflicts tool," but apparently I didn't do it very well.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 6, 2017

Codecov Report

Merging #1792 into master will increase coverage by 0.25%.

@@            Coverage Diff             @@
##           master    #1792      +/-   ##
==========================================
+ Coverage   46.05%   46.31%   +0.25%     
==========================================
  Files          22       22              
  Lines        5810     5845      +35     
  Branches     1460     1474      +14     
==========================================
+ Hits         2676     2707      +31     
- Misses       3134     3138       +4
Impacted Files Coverage Δ
outbound.js 13.46% <61.33%> (+2.26%)
configfile.js 68.82% <ø> (-1.18%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a83bf4...d31eb55. Read the comment docs.

codecov-io commented Feb 6, 2017

Codecov Report

Merging #1792 into master will increase coverage by 0.25%.

@@            Coverage Diff             @@
##           master    #1792      +/-   ##
==========================================
+ Coverage   46.05%   46.31%   +0.25%     
==========================================
  Files          22       22              
  Lines        5810     5845      +35     
  Branches     1460     1474      +14     
==========================================
+ Hits         2676     2707      +31     
- Misses       3134     3138       +4
Impacted Files Coverage Δ
outbound.js 13.46% <61.33%> (+2.26%)
configfile.js 68.82% <ø> (-1.18%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a83bf4...d31eb55. Read the comment docs.

@msimerson msimerson merged commit c6e5d82 into haraka:master Feb 6, 2017

3 checks passed

codecov/patch 61.33% of diff hit (target 46.05%)
Details
codecov/project 46.31% (+0.25%) compared to 0a83bf4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

msimerson added a commit that referenced this pull request Feb 6, 2017

master -> v3 (#1812)
* More changes to try and fix unaquired socket errors

* Fix lint errors

* Fix log functions and more lint cleanups

* Another small logging fix

* Test for log methods added

* This may or may not fix issues with short atts.

More force end attempts

Finish cleaning up sending of all data

* Fix logger errors

* Don't error on re-release with non-pool sockets

* Fix error logging in test

* add an additional plugin search path to account for the module-based plugins that live in the same node_modules folder as the Haraka installed via NPM (#1805)

* replace connect.fcrdns with npm package (#1810)

* replace connect.fcrdns with npm package

* Create an outbound queue filename handler (#1792)

* create a new method for handling filenames within the outbound queue
* convert to result store module

* when proxy enabled, update remote.is_private too (#1811)

reported by golden_receiver on #haraka

msimerson added a commit that referenced this pull request Feb 6, 2017

master -> v2 (#1813)
* More changes to try and fix unaquired socket errors

* Fix lint errors

* Fix log functions and more lint cleanups

* Another small logging fix

* Test for log methods added

* This may or may not fix issues with short atts.

More force end attempts

Finish cleaning up sending of all data

* Fix logger errors

* Don't error on re-release with non-pool sockets

* Fix error logging in test

* add an additional plugin search path to account for the module-based plugins that live in the same node_modules folder as the Haraka installed via NPM (#1805)

* replace connect.fcrdns with npm package (#1810)

* replace connect.fcrdns with npm package

* Create an outbound queue filename handler (#1792)

* create a new method for handling filenames within the outbound queue
* convert to result store module

* when proxy enabled, update remote.is_private too (#1811)

reported by golden_receiver on #haraka

msimerson added a commit that referenced this pull request Feb 11, 2017

merge master to v3 (#1818)
* More changes to try and fix unaquired socket errors

* Fix lint errors

* Fix log functions and more lint cleanups

* Another small logging fix

* Test for log methods added

* This may or may not fix issues with short atts.

More force end attempts

Finish cleaning up sending of all data

* Fix logger errors

* Don't error on re-release with non-pool sockets

* Fix error logging in test

* add an additional plugin search path to account for the module-based plugins that live in the same node_modules folder as the Haraka installed via NPM (#1805)

* replace connect.fcrdns with npm package (#1810)

* replace connect.fcrdns with npm package

* Create an outbound queue filename handler (#1792)

* create a new method for handling filenames within the outbound queue
* convert to result store module

* when proxy enabled, update remote.is_private too (#1811)

reported by golden_receiver on #haraka

* fix forwarding with clinet authentication  over TLS (forward to gmail) (#1803)

* fix forwarding with client authentication  over TLS (forward to gmail etc).

msimerson added a commit that referenced this pull request Feb 11, 2017

merge master to v2 (#1819)
* More changes to try and fix unaquired socket errors

* Fix lint errors

* Fix log functions and more lint cleanups

* Another small logging fix

* Test for log methods added

* This may or may not fix issues with short atts.

More force end attempts

Finish cleaning up sending of all data

* Fix logger errors

* Don't error on re-release with non-pool sockets

* Fix error logging in test

* add an additional plugin search path to account for the module-based plugins that live in the same node_modules folder as the Haraka installed via NPM (#1805)

* replace connect.fcrdns with npm package (#1810)

* replace connect.fcrdns with npm package

* Create an outbound queue filename handler (#1792)

* create a new method for handling filenames within the outbound queue
* convert to result store module

* when proxy enabled, update remote.is_private too (#1811)

reported by golden_receiver on #haraka

* fix forwarding with clinet authentication  over TLS (forward to gmail) (#1803)

* fix forwarding with client authentication  over TLS (forward to gmail etc).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment