New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace connect.fcrdns with npm package #1810

Merged
merged 2 commits into from Feb 6, 2017

Conversation

Projects
None yet
2 participants
@msimerson
Member

msimerson commented Feb 6, 2017

Changes proposed in this pull request:

  • replace connect.fcrdns with haraka-plugin-fcrdns

Checklist:

  • docs updated
  • tests updated
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 6, 2017

Codecov Report

Merging #1810 into master will not impact coverage.

@@           Coverage Diff           @@
##           master    #1810   +/-   ##
=======================================
  Coverage   45.98%   45.98%           
=======================================
  Files          22       22           
  Lines        5810     5810           
  Branches     1460     1460           
=======================================
  Hits         2672     2672           
  Misses       3138     3138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbff3d2...5872356. Read the comment docs.

codecov-io commented Feb 6, 2017

Codecov Report

Merging #1810 into master will not impact coverage.

@@           Coverage Diff           @@
##           master    #1810   +/-   ##
=======================================
  Coverage   45.98%   45.98%           
=======================================
  Files          22       22           
  Lines        5810     5810           
  Branches     1460     1460           
=======================================
  Hits         2672     2672           
  Misses       3138     3138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbff3d2...5872356. Read the comment docs.

@msimerson msimerson merged commit 0a83bf4 into haraka:master Feb 6, 2017

3 checks passed

codecov/patch Coverage not affected when comparing dbff3d2...5872356
Details
codecov/project 45.98% remains the same compared to dbff3d2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson deleted the msimerson:npm-fcrdns branch Feb 6, 2017

msimerson added a commit that referenced this pull request Feb 6, 2017

master -> v3 (#1812)
* More changes to try and fix unaquired socket errors

* Fix lint errors

* Fix log functions and more lint cleanups

* Another small logging fix

* Test for log methods added

* This may or may not fix issues with short atts.

More force end attempts

Finish cleaning up sending of all data

* Fix logger errors

* Don't error on re-release with non-pool sockets

* Fix error logging in test

* add an additional plugin search path to account for the module-based plugins that live in the same node_modules folder as the Haraka installed via NPM (#1805)

* replace connect.fcrdns with npm package (#1810)

* replace connect.fcrdns with npm package

* Create an outbound queue filename handler (#1792)

* create a new method for handling filenames within the outbound queue
* convert to result store module

* when proxy enabled, update remote.is_private too (#1811)

reported by golden_receiver on #haraka

msimerson added a commit that referenced this pull request Feb 6, 2017

master -> v2 (#1813)
* More changes to try and fix unaquired socket errors

* Fix lint errors

* Fix log functions and more lint cleanups

* Another small logging fix

* Test for log methods added

* This may or may not fix issues with short atts.

More force end attempts

Finish cleaning up sending of all data

* Fix logger errors

* Don't error on re-release with non-pool sockets

* Fix error logging in test

* add an additional plugin search path to account for the module-based plugins that live in the same node_modules folder as the Haraka installed via NPM (#1805)

* replace connect.fcrdns with npm package (#1810)

* replace connect.fcrdns with npm package

* Create an outbound queue filename handler (#1792)

* create a new method for handling filenames within the outbound queue
* convert to result store module

* when proxy enabled, update remote.is_private too (#1811)

reported by golden_receiver on #haraka

msimerson added a commit that referenced this pull request Feb 11, 2017

merge master to v3 (#1818)
* More changes to try and fix unaquired socket errors

* Fix lint errors

* Fix log functions and more lint cleanups

* Another small logging fix

* Test for log methods added

* This may or may not fix issues with short atts.

More force end attempts

Finish cleaning up sending of all data

* Fix logger errors

* Don't error on re-release with non-pool sockets

* Fix error logging in test

* add an additional plugin search path to account for the module-based plugins that live in the same node_modules folder as the Haraka installed via NPM (#1805)

* replace connect.fcrdns with npm package (#1810)

* replace connect.fcrdns with npm package

* Create an outbound queue filename handler (#1792)

* create a new method for handling filenames within the outbound queue
* convert to result store module

* when proxy enabled, update remote.is_private too (#1811)

reported by golden_receiver on #haraka

* fix forwarding with clinet authentication  over TLS (forward to gmail) (#1803)

* fix forwarding with client authentication  over TLS (forward to gmail etc).

msimerson added a commit that referenced this pull request Feb 11, 2017

merge master to v2 (#1819)
* More changes to try and fix unaquired socket errors

* Fix lint errors

* Fix log functions and more lint cleanups

* Another small logging fix

* Test for log methods added

* This may or may not fix issues with short atts.

More force end attempts

Finish cleaning up sending of all data

* Fix logger errors

* Don't error on re-release with non-pool sockets

* Fix error logging in test

* add an additional plugin search path to account for the module-based plugins that live in the same node_modules folder as the Haraka installed via NPM (#1805)

* replace connect.fcrdns with npm package (#1810)

* replace connect.fcrdns with npm package

* Create an outbound queue filename handler (#1792)

* create a new method for handling filenames within the outbound queue
* convert to result store module

* when proxy enabled, update remote.is_private too (#1811)

reported by golden_receiver on #haraka

* fix forwarding with clinet authentication  over TLS (forward to gmail) (#1803)

* fix forwarding with client authentication  over TLS (forward to gmail etc).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment