New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outbound logger #1827

Merged
merged 2 commits into from Feb 13, 2017

Conversation

Projects
None yet
3 participants
@baudehlo
Collaborator

baudehlo commented Feb 13, 2017

Fixes #1821

Matt Sergeant added some commits Feb 13, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 13, 2017

Codecov Report

Merging #1827 into master will decrease coverage by -1.46%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1827      +/-   ##
==========================================
- Coverage   46.23%   44.78%   -1.46%     
==========================================
  Files          22       22              
  Lines        5863     6103     +240     
  Branches     1474     1609     +135     
==========================================
+ Hits         2711     2733      +22     
- Misses       3152     3370     +218
Impacted Files Coverage Δ
outbound.js 12.56% <ø> (-0.89%)
configfile.js 70% <ø> (+1.17%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23caf58...c6f8eae. Read the comment docs.

codecov-io commented Feb 13, 2017

Codecov Report

Merging #1827 into master will decrease coverage by -1.46%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1827      +/-   ##
==========================================
- Coverage   46.23%   44.78%   -1.46%     
==========================================
  Files          22       22              
  Lines        5863     6103     +240     
  Branches     1474     1609     +135     
==========================================
+ Hits         2711     2733      +22     
- Misses       3152     3370     +218
Impacted Files Coverage Δ
outbound.js 12.56% <ø> (-0.89%)
configfile.js 70% <ø> (+1.17%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23caf58...c6f8eae. Read the comment docs.

@msimerson

This comment has been minimized.

Show comment
Hide comment
@msimerson

msimerson Feb 13, 2017

Member

LGTM.

Member

msimerson commented Feb 13, 2017

LGTM.

@baudehlo baudehlo merged commit bd577ad into master Feb 13, 2017

2 of 4 checks passed

codecov/patch 0% of diff hit (target 46.23%)
Details
codecov/project 44.78% (-1.46%) compared to 23caf58
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@msimerson msimerson deleted the fix_outbound_logger branch Feb 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment