New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helo.checks: bring plugin into alignment with docs #1833

Merged
merged 1 commit into from Feb 24, 2017

Conversation

Projects
None yet
2 participants
@msimerson
Member

msimerson commented Feb 21, 2017

Changes proposed in this pull request:

  • rename config setting mismatch to host_mismatch
    • there are 3 mismatch functions
    • with a backwards compat config shim
  • comment out boolean config settings
    • their defaults are already defined in the plugin
  • build the config.booleans from the global checks array
    • removes bunch of redundant tokens

Fixes #1832
Fixes msimerson/Mail-Toaster-6#202

Checklist:

  • docs updated
  • tests updated
helo.checks: bring plugin into alignment with docs
* rename config setting mismatch to host_mismatch
    * there are 3 mismatch functions
    * with a backwards compat config shim
* comment out boolean config settings
    * their defaults are already defined in the plugin
* build the config.booleans from the global `checks` array
    * removes bunch of redundant tokens
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 21, 2017

Codecov Report

Merging #1833 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1833      +/-   ##
=========================================
+ Coverage   46.23%   46.3%   +0.06%     
=========================================
  Files          22      22              
  Lines        5863    5863              
  Branches     1474    1474              
=========================================
+ Hits         2711    2715       +4     
+ Misses       3152    3148       -4
Impacted Files Coverage Δ
configfile.js 70% <ø> (+1.17%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7de7fd...c52fa3c. Read the comment docs.

codecov-io commented Feb 21, 2017

Codecov Report

Merging #1833 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1833      +/-   ##
=========================================
+ Coverage   46.23%   46.3%   +0.06%     
=========================================
  Files          22      22              
  Lines        5863    5863              
  Branches     1474    1474              
=========================================
+ Hits         2711    2715       +4     
+ Misses       3152    3148       -4
Impacted Files Coverage Δ
configfile.js 70% <ø> (+1.17%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7de7fd...c52fa3c. Read the comment docs.

@msimerson msimerson merged commit bba4cee into haraka:master Feb 24, 2017

3 checks passed

codecov/patch Coverage not affected when comparing d7de7fd...c52fa3c
Details
codecov/project 46.3% (+0.06%) compared to d7de7fd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson deleted the msimerson:helo.checks branch Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment