New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed documentation error for the 'check.authenticated' setting in the Rspamd plugin #1834

Merged
merged 1 commit into from Feb 22, 2017

Conversation

Projects
None yet
3 participants
@mmenzo
Contributor

mmenzo commented Feb 22, 2017

The documentation says that the check.authenticated setting should be set to false if you want to check the authenticated messages. However, this is the exact opposite of what the plugin does. The setting should be set to true if authenticated messages need to be checked.

Changes proposed in this pull request:

  • Fixed documentation error for the 'check.authenticated' setting in the Rspamd plugin

Checklist:

  • docs updated
  • tests updated
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 22, 2017

Codecov Report

Merging #1834 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1834   +/-   ##
=======================================
  Coverage   46.23%   46.23%           
=======================================
  Files          22       22           
  Lines        5863     5863           
  Branches     1474     1474           
=======================================
  Hits         2711     2711           
  Misses       3152     3152

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7de7fd...6dfd0e5. Read the comment docs.

codecov-io commented Feb 22, 2017

Codecov Report

Merging #1834 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1834   +/-   ##
=======================================
  Coverage   46.23%   46.23%           
=======================================
  Files          22       22           
  Lines        5863     5863           
  Branches     1474     1474           
=======================================
  Hits         2711     2711           
  Misses       3152     3152

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7de7fd...6dfd0e5. Read the comment docs.

@msimerson msimerson merged commit ef6e313 into haraka:master Feb 22, 2017

3 checks passed

codecov/patch Coverage not affected when comparing d7de7fd...6dfd0e5
Details
codecov/project 46.23% remains the same compared to d7de7fd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment