Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow "Unknown Result" and Socket Error to Try Next Host #1931
@@ Coverage Diff @@ ## master #1931 +/- ## ========================================== + Coverage 58.1% 58.12% +0.01% ========================================== Files 30 30 Lines 5891 5891 Branches 1475 1475 ========================================== + Hits 3423 3424 +1 + Misses 2468 2467 -1
In general, I approve of this change. However, I do wonder if we shouldn't inspect the error and only retry on another host if the error is one that choosing another clamd host would rectify. (ie, a connection error, etc.). If an attachment cannot be expanded or inspected (think: password encrypted attachments) there's little point and real costs involved in having N machines scan it instead of 1.
I have tested this with corrupted archives, corrupted executables, misnamed archives (i.e, renaming a file that isn't a zip file to have a zip extension), misnamed executables, and password protected archives. None of these situations activates the new code in this PR. ClamAV seems to handle these situations properly and returns a defined response that is not interpreted as an error condition by the clamd plugin. ClamAV even has options that allow you to control whether you want to allow "broken" executables and password protected content or block them.
I agree with your concern completely. If you can think of any other scenarios, I'd be happy to test those as well.
Yeah thanks - in recognition of this and other code I've added you to the Collaborators list for Haraka.…
On Mon, May 22, 2017 at 2:17 PM, Matt Simerson ***@***.***> wrote: Thanks for considering and testing. And thanks for this contribution! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1931 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAobYzrXu6v6Zpx3uV8RYUW-jH-5dRQzks5r8dEkgaJpZM4Nhzoc> .