New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #2334

Merged
merged 1 commit into from Feb 6, 2018

Conversation

Projects
None yet
2 participants
@gramakri
Collaborator

gramakri commented Feb 6, 2018

Fixes #
Fix a crash when logging is enabled.

2018-02-06T19:47:40.331Z [CRIT] [-] [core] TypeError: Cannot read property 'O' of undefined
2018-02-06T19:47:40.332Z [CRIT] [-] [core]     at socket.upgrade (/app/haraka/smtp_client.js:274:68)
2018-02-06T19:47:40.332Z [CRIT] [-] [core]     at TLSSocket.<anonymous> (/app/haraka/tls_socket.js:684:22)
2018-02-06T19:47:40.332Z [CRIT] [-] [core]     at emitNone (events.js:86:13)
2018-02-06T19:47:40.332Z [CRIT] [-] [core]     at TLSSocket.emit (events.js:185:7)
2018-02-06T19:47:40.332Z [CRIT] [-] [core]     at TLSSocket.<anonymous> (_tls_wrap.js:1109:16)
2018-02-06T19:47:40.332Z [CRIT] [-] [core]     at emitNone (events.js:91:20)
2018-02-06T19:47:40.332Z [CRIT] [-] [core]     at TLSSocket.emit (events.js:185:7)
2018-02-06T19:47:40.332Z [CRIT] [-] [core]     at TLSSocket._finishInit (_tls_wrap.js:610:8)
2018-02-06T19:47:40.332Z [CRIT] [-] [core]     at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:440:38)
@codecov

This comment has been minimized.

codecov bot commented Feb 6, 2018

Codecov Report

Merging #2334 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2334   +/-   ##
=======================================
  Coverage   59.56%   59.56%           
=======================================
  Files          28       28           
  Lines        6072     6072           
  Branches     1510     1510           
=======================================
  Hits         3617     3617           
  Misses       2455     2455
Impacted Files Coverage Δ
smtp_client.js 52.78% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d49071c...8974710. Read the comment docs.

@msimerson

thanks!

@msimerson msimerson merged commit 8c8ac64 into haraka:master Feb 6, 2018

3 of 4 checks passed

codecov/patch 0% of diff hit (target 59.56%)
Details
codecov/project 59.56% remains the same compared to d49071c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment