Skip to content

tweak for better behaviour as a live switcher #1

merged 2 commits into from Jan 30, 2012

3 participants

vlovich commented Oct 7, 2011

live-switching ability doesn't actually work since it keeps appending to head instead of replacing the existing theme (if one is present). custom styling of the theme can also be applied on top by ensuring that a theme for the same version is in the head before any custom styles.

also switched to google's https cdn so that sites behind a https domain can use this.

vlovich added some commits Oct 7, 2011
@vlovich vlovich switch to https google cdn f546838
@vlovich vlovich Improve switching ability
Don't keep adding stylesheets but instead re-using existing elements.
If already using a google stylesheet with a custom sheet, preserves
ordering of stylesheets so that custom style overrides remain in effect.

Requirement is that if already using google stylesheet in page, then it
must be using the same version as the themeswitcher is told to use

Should this be url rather than link?

.attr("href", url);

@harborhoffer harborhoffer merged commit 8b89f36 into harborhoffer:master Jan 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.