From cc7b2488362a13fac723185aa874f7d815aebb81 Mon Sep 17 00:00:00 2001 From: Felix Divo Date: Sun, 2 Jun 2019 22:33:59 +0200 Subject: [PATCH 1/2] Add wrongly removed statement back to codebase This was removed in the process of making the linter happy. But it is required since it changes `num_channels`. @christiansandberg this fixes the problem found by you --- can/interfaces/kvaser/canlib.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/can/interfaces/kvaser/canlib.py b/can/interfaces/kvaser/canlib.py index f16004c3b..6f9943d47 100644 --- a/can/interfaces/kvaser/canlib.py +++ b/can/interfaces/kvaser/canlib.py @@ -424,7 +424,8 @@ def __init__(self, channel, can_filters=None, **kwargs): self.single_handle = single_handle num_channels = ctypes.c_int(0) - # log.debug("Res: %d", canGetNumberOfChannels(ctypes.byref(num_channels))) + canGetNumberOfChannels(ctypes.byref(num_channels)) + # log.debug("canGetNumberOfChannels(): %d", canGetNumberOfChannels(ctypes.byref(num_channels))) num_channels = int(num_channels.value) log.info("Found %d available channels", num_channels) for idx in range(num_channels): From c89ca5f9574fb7219ae8888c242fa8b25c8d3ad4 Mon Sep 17 00:00:00 2001 From: Felix Divo Date: Mon, 3 Jun 2019 10:23:02 +0200 Subject: [PATCH 2/2] remove unused commented out logging --- can/interfaces/kvaser/canlib.py | 1 - 1 file changed, 1 deletion(-) diff --git a/can/interfaces/kvaser/canlib.py b/can/interfaces/kvaser/canlib.py index 6f9943d47..89a05af1e 100644 --- a/can/interfaces/kvaser/canlib.py +++ b/can/interfaces/kvaser/canlib.py @@ -425,7 +425,6 @@ def __init__(self, channel, can_filters=None, **kwargs): num_channels = ctypes.c_int(0) canGetNumberOfChannels(ctypes.byref(num_channels)) - # log.debug("canGetNumberOfChannels(): %d", canGetNumberOfChannels(ctypes.byref(num_channels))) num_channels = int(num_channels.value) log.info("Found %d available channels", num_channels) for idx in range(num_channels):