setup.py: require pytest-runner only when necessary #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #633 +/- ##
==========================================
+ Coverage 61.48% 63.18% +1.7%
==========================================
Files 66 66
Lines 5888 5883 -5
==========================================
+ Hits 3620 3717 +97
+ Misses 2268 2166 -102 |
Codecov Report
@@ Coverage Diff @@
## develop #633 +/- ##
========================================
Coverage 63.14% 63.14%
========================================
Files 66 66
Lines 5904 5904
========================================
Hits 3728 3728
Misses 2176 2176 |
felixdivo
added
QA
felixdivo
approved these changes
Jul 1, 2019
Collaborator
felixdivo
left a comment
felixdivo
left a comment
There was a problem hiding this comment.
This is cool, except that I would document it with the given link somewhere near needs_pytest.
Contributor
Author
|
Sure, no problem, I can update the PR accordingly ;) Thanks ! |
Contributor
Author
|
Updated :) |
Collaborator
|
Then thank you very much for your contribution! It seems like the black formatter is not yet completely convinced of the beauty of that code. If he is, we can merge this. ;) |
This optimizes setup.py for cases when pytest-runner is not needed, using the approach that is suggested upstream: https://pypi.python.org/pypi/pytest-runner#conditional-requirement
Contributor
Author
|
Doh, I will update ;) |
Contributor
Author
|
Seems Ok now :) |
Collaborator
|
@texierp Thanks for the contribution! 😄 |
hardbyte
added a commit
that referenced
this pull request
Jul 23, 2019
hardbyte
added a commit
that referenced
this pull request
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes setup.py for cases when pytest-runner is not needed,
using the approach that is suggested upstream:
https://pypi.python.org/pypi/pytest-runner#conditional-requirement