Fix two typos in the BufferedReader docstring #815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #815 +/- ##
========================================
Coverage 69.83% 69.83%
========================================
Files 70 70
Lines 6603 6603
========================================
Hits 4611 4611
Misses 1992 1992 |
Collaborator
|
Thanks for your PR. However, the second "iff" is intentional as it stands for "if and only if". We can also delete it if it confuses people I guess, since it is mostly (only?) used in mathematical contexts. I have no strong feelings about this. @hardbyte What do you think? |
Owner
|
Yeah lets aim to be more inclusive in our language :-) |
hardbyte
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.