Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed code block notation to runkit executable block for variable.md #13

Closed
wants to merge 2 commits into from

Conversation

yashwanth2804
Copy link

@yashwanth2804 yashwanth2804 commented Dec 2, 2018

Please make sure that github dont support {% runkit %} tag but dev.to does, so change any occurence of markdown code block to runkit.

this is actual template.

{% runkit
// hidden setup JavaScript code goes in this preamble area
const hiddenVar = 42
%}
// visible, reader-editable JavaScript code goes here
console.log(hiddenVar)
{% endrunkit %}

Thank you for the great article once again, I wish i had time contributing to this.

Please make sure that github don't support {% runkit %} tag but dev.to does, so change any occurence of markdown code block to runkit.

this is actual template.

{% runkit
// hidden setup JavaScript code goes in this preamble area
const hiddenVar = 42
%}
// visible, reader-editable JavaScript code goes here
console.log(hiddenVar)
{% endrunkit %} 

Thank you for the great article once again, I wish i had time contributing to this.
Changed code block notation to runkit executable block
@hardy613
Copy link
Owner

Hey,

I think I understand, ill try this out on dev.to

@yashwanth2804
Copy link
Author

@hardy613 have edited post on dev

@hardy925
Copy link
Collaborator

hardy925 commented Dec 30, 2018

Hey, I did try this on my post; unfortunately it seems the embedded version of runkit used on dev.to does not have support for template literals. Unless I am missing something.

Markdown:

screenshot from 2018-12-30 14-43-19

Result:

screenshot from 2018-12-30 14-42-23

@hardy925 hardy925 self-assigned this Dec 30, 2018
@hardy925 hardy925 added enhancement New feature or request help wanted Extra attention is needed labels Dec 30, 2018
@yashwanth2804
Copy link
Author

I think the line 2 has issues,
it should be
const str = `Here's my favorite number ${number}`;

@hardy925
Copy link
Collaborator

@yashwanth2804

I provided two images, one being the mark-up (first image) and you can see I have the template literal syntax correct in the markup however it is not correct in the runkit demo.

I am going to close this request as it seems runkit is not supporting es6 template literals, again if I am missing something or if you can provide an example (using dev.to's runkit embedded version) feel free to re-open.

Thank you.

@hardy925 hardy925 closed this Dec 31, 2018
@hardy925 hardy925 added wontfix This will not be worked on and removed help wanted Extra attention is needed labels Dec 31, 2018
@hardy925
Copy link
Collaborator

@yashwanth2804

It is def an an issue with dev.to markup parser, as you can see here:
screen shot 2018-12-31 at 11 46 33 am

RunKit works fine with template literals in their demo environment.

@hardy925
Copy link
Collaborator

@yashwanth2804 I have opened an issue: forem/forem#1431

@hardy925 hardy925 removed the wontfix This will not be worked on label Jan 1, 2019
@hardy925
Copy link
Collaborator

The issue report has been approved on dev.to. This request may come sooner than I thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants