Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: harfbuzz/harfbuzz
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b5f25844fbdd
Choose a base ref
...
head repository: harfbuzz/harfbuzz
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b969a82e30f0
Choose a head ref
  • 19 commits
  • 16 files changed
  • 3 contributors

Commits on Feb 12, 2018

  1. Another try at fixing multiple-defintion of NullPool 

    This one might do it...
    @behdad
    behdad committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    dde6448 View commit details
    Browse the repository at this point in the history

  2. Fix more warnings

    @behdad
    behdad committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    d33ba16 View commit details
    Browse the repository at this point in the history

  3. Add Sun compiler to no-visibility as well 

    Fixes #776
    @behdad
    behdad committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    0db6c6f View commit details
    Browse the repository at this point in the history

  4. Add MSVC to no-visibility list

    @behdad
    behdad committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    90d1c74 View commit details
    Browse the repository at this point in the history

  5. Remove linker selection from hb-ucdn 

    Since this is a convenience library, it's not actually linked. Or so I think.
Hoping this might fix this Appveyor failure:

https://ci.appveyor.com/project/harfbuzz/harfbuzz/build/job/9884jyb5vryja9pw

Making all in hb-ucdn
make[4]: Entering directory '/c/projects/harfbuzz/src/hb-ucdn'
  CC       libhb_ucdn_la-ucdn.lo
  GEN      libhb-ucdn.la
/bin/sh: libhb_ucdn_la-ucdn.lo: command not found
make[4]: *** [Makefile:404: libhb-ucdn.la] Error 127
make[4]: Leaving directory '/c/projects/harfbuzz/src/hb-ucdn'
make[3]: *** [Makefile:2548: all-recursive] Error 1
make[3]: Leaving directory '/c/projects/harfbuzz/src'
make[2]: *** [Makefile:1382: all] Error 2
make[2]: Leaving directory '/c/projects/harfbuzz/src'
make[1]: *** [Makefile:486: all-recursive] Error 1
make[1]: Leaving directory '/c/projects/harfbuzz'
make: *** [Makefile:418: all] Error 2
    @behdad
    behdad committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    7747bdb View commit details
    Browse the repository at this point in the history

  6. Add Travis based Coverity trigger (#778)

    @ebraminio
    ebraminio authored Feb 12, 2018
    Configuration menu
    Copy the full SHA
    7daa282 View commit details
    Browse the repository at this point in the history

  7. minor

    @ebraminio
    ebraminio authored Feb 12, 2018
    Configuration menu
    Copy the full SHA
    82e0475 View commit details
    Browse the repository at this point in the history

  8. Add --with-stdcpp for ossfuzzer and mupdf use (#770)

    @ebraminio
    ebraminio authored Feb 12, 2018
    3 Configuration menu
    Copy the full SHA
    2efc896 View commit details
    Browse the repository at this point in the history

  9. Apply check-defs.sh to -icu and -subset, toward mingw fix (#780)

    @ebraminio
    ebraminio authored Feb 12, 2018
    Configuration menu
    Copy the full SHA
    a9b650d View commit details
    Browse the repository at this point in the history

  10. Minor, don't skip the whole test when one .def file not found

    @ebraminio
    ebraminio authored Feb 12, 2018
    Configuration menu
    Copy the full SHA
    16f5b53 View commit details
    Browse the repository at this point in the history

  11. Minor

    @ebraminio
    ebraminio authored Feb 12, 2018
    Configuration menu
    Copy the full SHA
    133e17f View commit details
    Browse the repository at this point in the history

  12. Fix symbol exporting issue on msys2 and ✅ bringing all the bots (#781)

    @ebraminio
    ebraminio authored Feb 12, 2018
    1 Configuration menu
    Copy the full SHA
    91f0d51 View commit details
    Browse the repository at this point in the history

  13. Rename --with-stdcpp → --with-libstdc++ 

    Also improve wording a bit and fix make check in --with-libstdc++=yes.
    @khaledhosny @behdad
    khaledhosny authored and behdad committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    0b94d59 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2018

  1. Move linker specifying to a better place

    @ebraminio @behdad
    ebraminio authored and behdad committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    4af3c5e View commit details
    Browse the repository at this point in the history

  2. Allow libharfbuzz-subset to link to libstdc++ 

    We want to use it instead of reinventing hashmap...

Also, don't change linker for ICU since libicu also uses libstdc++.
    @behdad
    behdad committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    42040a2 View commit details
    Browse the repository at this point in the history

  3. [subset] Remove unreachable code 

    sanitizer.sanitize never return nullptr.
    @behdad
    behdad committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    3d66f44 View commit details
    Browse the repository at this point in the history

  4. Use hb_face_get_upem() instead of face->get_upem() 

    Such that hmtx accelerator can be used from libharfbuzz-subset.
    @behdad
    behdad committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    96f1f52 View commit details
    Browse the repository at this point in the history

  5. [subset] Allocate bulk memory with malloc(), not calloc() 

    We use calloc() to allocate simple structs and set them to zero.
For bulk memory, use malloc() that doesn't zero.
    @behdad
    behdad committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    97a2f03 View commit details
    Browse the repository at this point in the history

  6. Pass no-libstdc++ flags only to libraries suppressing it

    @behdad
    behdad committed Feb 13, 2018
    2 Configuration menu
    Copy the full SHA
    b969a82 View commit details
    Browse the repository at this point in the history
Loading