Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: harfbuzz/harfbuzz
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c4308f895aef
Choose a base ref
...
head repository: harfbuzz/harfbuzz
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a5a27073cfff
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Aug 14, 2014

  1. Make hb_object_t members private 

    In preparation for fixing:
https://code.google.com/p/chromium/issues/detail?id=403594
    @behdad
    behdad committed Aug 14, 2014
    Configuration menu
    Copy the full SHA
    cd7ea4f View commit details
    Browse the repository at this point in the history

  2. Remove this==NULL check from face->reference_table() 

    Not supposed to happen, and apparently this is undefined in C++.
https://code.google.com/p/chromium/issues/detail?id=403594
    @behdad
    behdad committed Aug 14, 2014
    Configuration menu
    Copy the full SHA
    cc3b2d4 View commit details
    Browse the repository at this point in the history

  3. Rewrite this==NULL checks to avoid undefined behavior 

    Fixes https://code.google.com/p/chromium/issues/detail?id=403594
    @behdad
    behdad committed Aug 14, 2014
    Configuration menu
    Copy the full SHA
    a5a2707 View commit details
    Browse the repository at this point in the history
Loading