Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null cmap accelerator_t is wrong, possibly other accelerators as well #1146

Closed
behdad opened this issue Aug 28, 2018 · 3 comments
Closed

Null cmap accelerator_t is wrong, possibly other accelerators as well #1146

behdad opened this issue Aug 28, 2018 · 3 comments
Assignees
@behdad
Labels
bug

Comments

@behdad
Copy link
Member

behdad commented Aug 28, 2018

It doesn't have subtable and subtable_uvs pointing to null objects for those.
@behdad behdad self-assigned this Aug 28, 2018
@behdad behdad added the bug label Aug 28, 2018
@behdad
Copy link
Member Author

behdad commented Oct 12, 2018

Okay, pretty much all our accelerator_t objects we refer to from hb_face_t have null-pointer-dereference problems. Not sure how to solve these.

@behdad
Copy link
Member Author

behdad commented Oct 12, 2018

I mean, most of our uses don't get to access these if hb_ot_face_data fails to ensure. Maybe that's it. That there's no easy way out.

@behdad
Copy link
Member Author

behdad commented Oct 15, 2018

Quick checking, cmap, cblc/cbdt, sbix, svg, glyf, hmtx, kern, gdef, post are affected. Not sure what the best resolution is.

behdad added a commit that referenced this issue Nov 4, 2018
@behdad
Add hb_nonnull_ptr_t
fb0f30f 
Towards fixing #1146
behdad added a commit that referenced this issue Nov 4, 2018
@behdad
Fix null accelerator's
0b0b38e 
Fixes all except for cmap.  To be done separately.

Part of #1146
@behdad behdad closed this as completed in bb380ec Nov 5, 2018
ebraminio pushed a commit to ebraminio/harfbuzz that referenced this issue Nov 24, 2018
@behdad @ebraminio
Add hb_nonnull_ptr_t
0c96fa5 
Towards fixing harfbuzz#1146
ebraminio pushed a commit to ebraminio/harfbuzz that referenced this issue Nov 24, 2018
@behdad @ebraminio
Fix null accelerator's
47059af 
Fixes all except for cmap.  To be done separately.

Part of harfbuzz#1146
ebraminio pushed a commit to ebraminio/harfbuzz that referenced this issue Nov 24, 2018
@behdad @ebraminio
[cmap] Make null accelerator safe
59f274e 
Fixes harfbuzz#1146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@behdad behdad

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@behdad