Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ubsan bot needs rtti? #1174

Closed
behdad opened this issue Sep 24, 2018 · 4 comments
Closed

ubsan bot needs rtti? #1174

behdad opened this issue Sep 24, 2018 · 4 comments

Comments

@behdad
Copy link
Member

behdad commented Sep 24, 2018

https://circleci.com/gh/harfbuzz/harfbuzz/33467

Let's build it with stdc++.
@behdad
Copy link
Member Author

behdad commented Sep 24, 2018

Actually I'm not sure. This:

avr-llvm/llvm#168

suggests adding -fno-rtti. Which we already do. I'll try locally and figure out.

@behdad
Copy link
Member Author

behdad commented Sep 24, 2018

It's not rtti. Guess we need to use C++ compiler even for C tests. Trying.

@behdad
Copy link
Member Author

behdad commented Sep 24, 2018

I'm out of ideas. Couldn't get it to work.

behdad added a commit that referenced this issue Sep 24, 2018
@behdad
[circleci] Disable msan and ubsan builds
45f5aa9 
#1174
#1175
@behdad
Copy link
Member Author

behdad commented Sep 24, 2018

Ok, making test/api dir use C++ linker to link C code fixes this.

@behdad behdad closed this as completed in d07f311 Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@behdad