warning: 'typename' occurs outside of a template [-Wc++11-extensions]

[ebraminio]

Some of the older compilers bots are full of these

../src/hb-buffer.hh:229:50: warning: 'typename' occurs outside of a template [-Wc++11-extensions]
    if (unlikely (!make_room_for (0, 1))) return Crap(hb_glyph_info_t);
                                                 ^
../src/hb-null.hh:93:50: note: expanded from macro 'Crap'
#define Crap(Type) Crap<typename hb_remove_const<typename hb_remove_reference<Type>::value>::value>()
                                                 ^
In file included from ../src/hb-aat-map.cc:31:
In file included from ../src/hb-aat-layout.hh:32:
In file included from ../src/hb-ot-shape.hh:32:
In file included from ../src/hb-ot-map.hh:32:
../src/hb-buffer.hh:229:50: warning: 'typename' occurs outside of a template [-Wc++11-extensions]
../src/hb-null.hh:93:25: note: expanded from macro 'Crap'
#define Crap(Type) Crap<typename hb_remove_const<typename hb_remove_reference<Type>::value>::value>()
                        ^

And we disabled llvm-gccc because of it, e1b8e933f0

But we need to do something about and reviving llvm-gcc bots afterward (till we require C++11 officially).

[behdad]

You keep talking about "...we need to do something about and reviving..." Unless you are going to do something about it, I don't need to hear it again. :)

[ebraminio]

Hehe, hasn't digest the change yet to be honest :)

[behdad]

Nothing to be done here.

[ebraminio]

Dupe to #1419