Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeezaPro rendering doesn't look good #1405

Closed
ebraminio opened this issue Nov 23, 2018 · 4 comments
Closed

GeezaPro rendering doesn't look good #1405

ebraminio opened this issue Nov 23, 2018 · 4 comments
Labels
Chrome Chrome/Chromium project related issues and requests

Comments

@ebraminio
Copy link
Collaborator

ebraminio commented Nov 23, 2018 •
edited
Loading

From a 10.12 machine "Geeza Pro Regular; 12.0d1e3; 2016-07-17",

util/hb-view /System/Library/Fonts/GeezaPro.ttc -u "U+0627,U+0644,U+0623,U+064E,U+0628,U+0652,U+062C,U+064E,U+062F,U+0650,U+064A,U+064E,U+0651,U+0629,U+0640,U+0627,U+0644,U+0639,U+064E,U+0631,U+064E,U+0628,U+0650,U+064A,U+064E,U+0651,U+0629" --shaper ot | display

util/hb-view /System/Library/Fonts/GeezaPro.ttc -u "U+0627,U+0644,U+0623,U+064E,U+0628,U+0652,U+062C,U+064E,U+062F,U+0650,U+064A,U+064E,U+0651,U+0629,U+0640,U+0627,U+0644,U+0639,U+064E,U+0631,U+064E,U+0628,U+0650,U+064A,U+064E,U+0651,U+0629" --shaper coretext | display

image
@ebraminio
Copy link
Collaborator Author

https://github.com/harfbuzz/harfbuzz/blob/master/test/shaping/data/in-house/tests/macos-10.12.tests#L6 should be updated after the fix

@behdad
Copy link
Member

behdad commented Nov 23, 2018

Ugh. Did I break that? We desperately need tests for this. So yeah, thanks.

@behdad behdad closed this as completed in 7489622 Nov 23, 2018
@behdad
Copy link
Member

behdad commented Nov 23, 2018

Fixed. Please update tests.

@ebraminio ebraminio added the Chrome Chrome/Chromium project related issues and requests label Nov 23, 2018
@ebraminio
Copy link
Collaborator Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Chrome Chrome/Chromium project related issues and requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behdad @ebraminio