MSVC x64 warnings C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)

[cpeterso]

I see the following MSVC x64 compiler warnings when building harfbuzz (as part of Firefox) for Win64. MSVC is complaining about #define FLAG_SAFE(x) (1U << (x)).

harfbuzz/src/hb-ot-shape-complex-indic.cc(240) : warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
harfbuzz/src/hb-ot-shape-complex-indic.cc(250) : warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
harfbuzz/src/hb-ot-shape-complex-indic.cc(966) : warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
harfbuzz/src/hb-ot-shape-complex-indic.cc(1518) : warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
harfbuzz/src/hb-ot-shape-complex-indic.cc(1672) : warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
harfbuzz/src/hb-ot-shape-complex-indic.cc(1819) : warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)

[behdad]

Thanks. Can you test the fix?

[cpeterso]

Works for me. You have fixed all the Win64 warnings! :-)

I will submit a patch to update Firefox's HarfBuzz snapshot soon.

[behdad]

Great!