Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering for Tibetan long vowel U is broken #417

Closed
domschl opened this issue Feb 11, 2017 · 15 comments

Comments

Projects
None yet
6 participants
@domschl
Copy link
Contributor

commented Feb 11, 2017

On Linux and Android, the Tibetan syllable U (ཨཱུ) is rendered incorrectly.

The following site shows the browser-output when rendering hUM and U, together with bitmaps for the correctly rendered glyphs: Test-site

Affected are:

  • Android (tested with 7.1.2beta)
  • Linux (tested with harfbuzz 1.4.2)
  • macOS & Chrome: rendering seems ok within macOS fonts Kokonor and Kailasa, but breaks with all other Tibetan fonts tested.
@KrasnayaPloshchad

This comment has been minimized.

Copy link

commented Feb 12, 2017

Confirmed on Windows 10.

Firefox 51.0.1
1
2
BabelPad 9.0.0.3
3
4
LibreOffice 5.3
5
6

What I got surprised are: with Microsoft Himalaya the vowel signs are upside down, with Jomolhari one vowel sign failed to join. Since HarfBuzz is also intergrated in LibreOffice (this includes new cross-platform text layout engine based on HarfBuzz), such problems become wider spread that need to pay more attentions to.

@roozbehp roozbehp added the Android label Feb 13, 2017

@behdad behdad added the bug label Mar 2, 2017

@eroux

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2017

With latest git, running

./hb-view --output-format=png --output-file=U.png --language=tibt --script=tibt /usr/share/fonts/truetype/noto/NotoSansTibetan-Regular.ttf ཨཱུ

gives

u

(which is wrong)

@eroux

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2017

After a git bisect, I can tell that the bug has been introduced in 2f560ee

@domschl

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2017

@eroux : Nice find! Just changing the one line back seems to fix the rendering of long vowel U for me. I have tested on Arch linux, Chrome and LibreOffice work fine. Of course this needs to be checked by the original author of 2f560ee, don't know if this would break something else.

@jungshik

This comment has been minimized.

Copy link

commented Apr 19, 2017

@behdad, it seems that matching uniscribe breaks other fonts. What would be a resolution?

@eroux

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2017

@jungshik what do you mean specifically? Is that related to Tibetan or is it a more general statement?

@jungshik

This comment has been minimized.

Copy link

commented Apr 19, 2017

@eroux, I'm referring to HarfBuzz commit 2f560ee which changed the behavior of Tibetan shaper to match the behavior of Uniscribe. That commit was found by @domschl with bisecting.

@eroux

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2017

What I meant is: what are you referring to when you say

  • "matching uniscribe": is it this change in particular or the general idea of matching uniscribe?
  • "breaks other fonts": what exactly does get broken? which fonts? with what unicode sequence?
@domschl

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2017

It was @eroux who found the cause of the problem. Currently, we are suggesting a possible fix (#443) which would repair the Tibetan, while keeping the improvements that were intended with 2f560ee . The fix requires a thorough review, which will be the next step.

@jungshik

This comment has been minimized.

Copy link

commented Apr 19, 2017

"matching uniscribe": is it this change in particular or the general idea of matching uniscribe?

My comment is in this bug so I meant this particular issue.

"breaks other fonts": what exactly does get broken? which fonts? with what unicode sequence?

This bug is about that, no? Microsoft Himalaya is fine, but other Tibetan fonts do not work as expected.

@eroux

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2017

I'm still unsure what your point is... asking it in a different way, do you think #443 has some bugs left or is it fine for you?

@behdad behdad closed this in #443 Jul 14, 2017

@eroux

This comment has been minimized.

Copy link
Contributor

commented Jul 14, 2017

Thanks a lot for the fix!

@domschl

This comment has been minimized.

Copy link
Contributor Author

commented Jul 14, 2017

Tx all! the long-U is back!

@KrasnayaPloshchad

This comment has been minimized.

Copy link

commented Jul 22, 2017

This bugfix would landing in Firefox 56, I hope LibreOffice would following soon.

@KrasnayaPloshchad

This comment has been minimized.

Copy link

commented Aug 8, 2017

I hope LibreOffice would following soon.

TDF Bugzilla: https://bugs.documentfoundation.org/show_bug.cgi?id=109142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.