Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_GNU_SOURCE is defined too late #693

Closed
kbrow1i opened this issue Jan 10, 2018 · 1 comment · Fixed by #697
Closed

_GNU_SOURCE is defined too late #693

kbrow1i opened this issue Jan 10, 2018 · 1 comment · Fixed by #697

Comments

@kbrow1i
Copy link
Contributor

kbrow1i commented Jan 10, 2018

0001-Move-the-define-of-_GNU_SOURCE-to-the-top-of-hb-priv.txt
harfbuzz 1.7.4 doesn't build on Cygwin because _GNU_SOURCE is defined too late in hb-private.hh. According to https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html, feature test macro defines "must come before any #include of a system header file. It is best to make them the very first thing in the file, preceded only by comments."

The attached patch moves the define of _GNU_SOURCE to the top of hb-private.hh and fixes the build.

@ebraminio
Copy link
Collaborator

We are testing harfbuzz on msys2 on CI, not sure why it fails on Cygwin but as it wouldn't break others work we like to have that patch! Uploaded it as PR #697 feel free to open PR yourself next time if you like to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants