Skip to content

hb-shape broken for multi-line input in versions 1.7.5 and 1.7.6 (1.7.4 works) #888

@cjchapman

Description

@cjchapman

I see this same problem in OS X builds of hb-shape, but I'm using the pre-built Windows EXEs from the GitHub releases to illustrate the issue below.

The NotoSansDevanagari-Regular.ttf file I used is from here:
https://noto-website-2.storage.googleapis.com/pkgs/NotoSansDevanagari-unhinted.zip

The hi.txt file I used is from here:
https://github.com/googlei18n/harfbuzz-testing-wikipedia/blob/master/bz2/hi.txt.bz2

When I use the 1.7.4 version of hb-shape, I get the output I expect:

C:\Users\cchapman\Downloads>harfbuzz-1.7.4-win32\hb-shape.exe --font-file=NotoSansDevanagari-Regular.ttf --text-file=hi.txt | head
[kadeva=0+762|evowelsigndeva=0@-221,0+0]
[madeva=0+598|evowelsignanusvaradeva=0+0]
[kadeva=0+762|iivowelsign3deva=0+259]
[hadeva=0+531|aivowelsigndeva=0+0]
[kadeva=0+762|aavowelsigndeva=0+259]
[audeva=0+1023|radeva=1+409]
[sadeva=0+676|evowelsigndeva=0+0]
[kadeva=0+762|ovowelsigndeva=0+259]
[hadeva=0+531|aivowelsigndeva=0+0|dandadeva=2+379]
[edeva=0+553|kadeva=1+762]

However, when I use 1.7.5 or 1.7.6, I get unexpected output after the first line:

C:\Users\cchapman\Downloads>harfbuzz-1.7.5-win32\hb-shape.exe --font-file=NotoSansDevanagari-Regular.ttf --text-file=hi.txt | head
[kadeva=0+762|evowelsigndeva=0@-221,0+0]
[vadeva=0+556|aavowelsigndeva=0+259|radeva=2+409|aavowelsigndeva=2+259]
[.notdef=0+600|.notdef=1+600|nadeva=2+555|uvowelsigndeva=2+0|sadeva=4+676|aavowelsigndeva=4+259|radeva=6+409]
[.notdef=0+600|ivowelsigndeva=0+259|uni25CC=0+510|dadhadeva=2+791]
[uni25CC=0+510|evowelsigndeva=0+0|ivowelsign01deva=1+259|radeva=1+409|kadeva=3+762|aavowelsigndeva=3+259]
[.notdef=0+600|.notdef=1+600|madeva=2+598|evowelsignanusvaradeva=2+0]
[.notdef=0+600|.notdef=1+600]
[taprehalfdeva=0+306|yadeva=2+580]
[.notdef=0+600|.notdef=1+600|uni25CC=1+510|viramadeva=1+0|radeva=3+409|aavowelsigndeva=3+259|madeva=5+598|aavowelsigndeva=5+259|ivowelsign06deva=7+259|nnadeva=7+723|kadeva=9+762]
[.notdef=0+600|ivowelsigndeva=0+259|uni25CC=0+510|edeva=2+553]

C:\Users\cchapman\Downloads>harfbuzz-1.7.6-win32\hb-shape.exe --font-file=NotoSansDevanagari-Regular.ttf --text-file=hi.txt | head
[kadeva=0+762|evowelsigndeva=0@-221,0+0]
[vadeva=0+556|aavowelsigndeva=0+259|radeva=2+409|aavowelsigndeva=2+259]
[.notdef=0+600|.notdef=1+600|nadeva=2+555|uvowelsigndeva=2+0|sadeva=4+676|aavowelsigndeva=4+259|radeva=6+409]
[.notdef=0+600|ivowelsigndeva=0+259|uni25CC=0+510|dadhadeva=2+791]
[uni25CC=0+510|evowelsigndeva=0+0|ivowelsign01deva=1+259|radeva=1+409|kadeva=3+762|aavowelsigndeva=3+259]
[.notdef=0+600|.notdef=1+600|madeva=2+598|evowelsignanusvaradeva=2+0]
[.notdef=0+600|.notdef=1+600]
[taprehalfdeva=0+306|yadeva=2+580]
[.notdef=0+600|.notdef=1+600|uni25CC=1+510|viramadeva=1+0|radeva=3+409|aavowelsigndeva=3+259|madeva=5+598|aavowelsigndeva=5+259|ivowelsign06deva=7+259|nnadeva=7+723|kadeva=9+762]
[.notdef=0+600|ivowelsigndeva=0+259|uni25CC=0+510|edeva=2+553]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions