Graphite2 dynamic loading #107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code is there for windows & Mac, but not yet tested on those platforms. I'm willing to work with someone wanting to do such a test. |
|
In response to a flagging of a memory leak around grfuncs, I have removed the alloc and now hold the funcs data structure as part of shaper_face_data, thus removing the leak. |
|
Humm. I don't think this is going to happen. If we ever want to do it, it should be done differently. See how hb-uniscribe is done for example. Ie. dl handle should be a global var. face and font data sould be the same as static build. There should be one ifdef only! |
gpgreen
pushed a commit
to gpgreen/harfbuzz
that referenced
this pull request
Jan 10, 2024
Update to freetype 0.4. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/107) <!-- Reviewable:end -->
gpgreen
pushed a commit
to gpgreen/harfbuzz
that referenced
this pull request
Jan 10, 2024
Therefore change feature name to match upstream's: servo/rust-freetype@342ad76 Also bump version of harfbuzz-sys to 0.4 like in PR harfbuzz#107.
gpgreen
pushed a commit
to gpgreen/harfbuzz
that referenced
this pull request
Jan 10, 2024
Update to freetype 0.5 Therefore change feature name to match upstream's: servo/rust-freetype@342ad76 Also bump version of harfbuzz-sys to 0.4 like in PR harfbuzz#107.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of people have asked me for a mechanism by which graphite may be dynamically loaded only when a Graphite font is used. I've struggled with the notion of this, but I think I understand it now. I hope that this can help everyone to have what they want for minimal cost.
This patch adds dynamic loading of graphite support for graphite fonts in harfbuzz. The three way configure option is now: --with-graphite2=no means no graphite support. --with-graphite2=yes means to build and link against an existing graphite library. --with-graphite2=auto means to build independently of any graphite library but to attempt to dynamically load graphite when a graphite font is encountered.
This patch has been built and tested on linux only at the moment.