Added caching into hb_ft_get_glyph_h_advance function. #1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Behdad, couldn't we always have this instead introducing a build option? |
Yep, agree. |
|
I need to figure out how to invalidate the cache if font size changes though... That's, complicated. |
behdad
added a commit
that referenced
this pull request
Sep 11, 2018
|
Done. I also added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added caching mentioned in #651.
In our tests hb_shape time decreased from 260ms to 10ms.
I have almost no experience with autoconf, please check if it's correct.