Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bots with address- and thread-sanitizer #1169

Merged
merged 1 commit into from
Sep 23, 2018

Conversation

ebraminio
Copy link
Collaborator

Fixes #1168

@ebraminio
Copy link
Collaborator Author

ebraminio added a commit that referenced this pull request Sep 22, 2018
ebraminio added a commit that referenced this pull request Sep 22, 2018
ebraminio added a commit that referenced this pull request Sep 22, 2018
ebraminio added a commit that referenced this pull request Sep 22, 2018
@ebraminio
Copy link
Collaborator Author

Fixed some of them, including subset related one so nothing in particular about hb-subset for now. Lets see how to fix the rest.

@ebraminio ebraminio mentioned this pull request Sep 22, 2018
@ebraminio ebraminio force-pushed the asantsan branch 8 times, most recently from 1088fb8 to 3afbe89 Compare September 22, 2018 21:25
@behdad
Copy link
Member

behdad commented Sep 23, 2018

For thread-sanitizer to have any use, we need to add multi-threaded test, and then just run that one with thread-sanitizer.

Also useful is undefined-behavior sanitizer, and memory sanitizer. Unfortunately doesn't seem like they can be combined...

@behdad
Copy link
Member

behdad commented Sep 23, 2018

But yeah, I think one bot is fine.

@behdad
Copy link
Member

behdad commented Sep 23, 2018

I'm merging and fixing the rest. Thanks.

@behdad behdad merged commit ae39a53 into harfbuzz:master Sep 23, 2018
@ebraminio ebraminio deleted the asantsan branch September 24, 2018 12:11
@ebraminio
Copy link
Collaborator Author

But yeah, I think one bot is fine.

Will do after we have all the bots green.

@behdad
Copy link
Member

behdad commented Sep 24, 2018

But yeah, I think one bot is fine.

Will do after we have all the bots green.

Since you set it up already, let's leave as is and see how long it takes them... I don't know how much setting up the bot takes in comparison to just running our stuff...

Also, @garretrieger will buy us an additional container...

@khaledhosny khaledhosny added the ci Continuous Integration label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants