-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bots with address- and thread-sanitizer #1169
Conversation
https://circleci.com/gh/harfbuzz/harfbuzz/33002 over to you guys I guess @behdad @garretrieger @rsheeter |
Fixed some of them, including subset related one so nothing in particular about hb-subset for now. Lets see how to fix the rest. |
1088fb8
to
3afbe89
Compare
For thread-sanitizer to have any use, we need to add multi-threaded test, and then just run that one with thread-sanitizer. Also useful is undefined-behavior sanitizer, and memory sanitizer. Unfortunately doesn't seem like they can be combined... |
But yeah, I think one bot is fine. |
I'm merging and fixing the rest. Thanks. |
Will do after we have all the bots green. |
Since you set it up already, let's leave as is and see how long it takes them... I don't know how much setting up the bot takes in comparison to just running our stuff... Also, @garretrieger will buy us an additional container... |
Fixes #1168