Add working but less prefect DirectWrite backend #134
Conversation
ebraminio
force-pushed
the
dwrite
branch
2 times, most recently
from
3a08cee to
d07eef9
Compare
ebraminio
force-pushed
the
dwrite
branch
2 times, most recently
from
9768b41 to
534e7cb
Compare
|
Behdad, this is far from prefect but may I suggest putting this on some branch? On anycase, I am open for your code reviews, at least for reaching to a point suitable for having it on a branch, so please have a look at. |
|
Since M$ making DirectWrite more competitiveness with Uniscribe, and more apps tend to use DirectWrite, the developments on |
|
Since Uniscribe seems to be just a backward compatibility wrapper around DirectWrite these days, do we gain much be using DirectWrite directly? After all these backends are just for testing and comparing HarfBuzz output to Uniscribe and nothing else. |
|
Eh, I got wrong materials about DirectWrite, sorry. |
|
Studying DW API given for Kashida justification was my only motivation for this which I am not saying is even a good one. I don't think I am the right person for this even as the lack of enough familiarity with Windows APIs and the fact that honestly I couldn't even find any clean solution on using mingw/cygwin autotools with directx API headers and actually I used a cmake build script with vs for this. However I hope this would be useful thing for further attempts at someday. |
Add working but less prefect DirectWrite backend
|
Should add buildsystem support for this. I'll give it a try when I have my Windows 10 machine around. |
Add into the NMake Makefiles to build the DirectWrite shaping backend, but as PR harfbuzz#134 mentions, this is considered to be in an experimental state, so don't include this in the build by default for now. This is most probably going to replace the Uniscribe backend eventually, since DirectWrite is meant to be Uniscribe's replacement, and is needed for Windows Store apps if a system shaping API is to be used.
|
Oh, thank you Behdad. I see this as a great step forward. As its known issues I explained on ML I was expecting see this on a branch moreover but this is even better. I doubt there would be any clean way to use dx headers with autotools system but the WIP NMake support seems is fixing this issue also finally. One suggestion, to prevent misuse of clients from the dx support for now, I think it would be nice to put some compiler directive (maybe Thank you |
|
As long as it's not easy to build with it, we should be fine. But feel free to send a PR. |
Add into the NMake Makefiles to build the DirectWrite shaping backend, but as PR harfbuzz#134 mentions, this is considered to be in an experimental state, so don't include this in the build by default for now. This is most probably going to replace the Uniscribe backend eventually, since DirectWrite is meant to be Uniscribe's replacement, and is needed for Windows Store apps if a system shaping API is to be used.
Add into the NMake Makefiles to build the DirectWrite shaping backend, but as PR harfbuzz#134 mentions, this is considered to be in an experimental state, so don't include this in the build by default for now. This is most probably going to replace the Uniscribe backend eventually, since DirectWrite is meant to be Uniscribe's replacement, and is needed for Windows Store apps if a system shaping API is to be used.
Add into the NMake Makefiles to build the DirectWrite shaping backend, but as PR harfbuzz#134 mentions, this is considered to be in an experimental state, so don't include this in the build by default for now. This is most probably going to replace the Uniscribe backend eventually, since DirectWrite is meant to be Uniscribe's replacement, and is needed for Windows Store apps if a system shaping API is to be used.
Add into the NMake Makefiles to build the DirectWrite shaping backend, but as PR harfbuzz#134 mentions, this is considered to be in an experimental state, so don't include this in the build by default for now. This is most probably going to replace the Uniscribe backend eventually, since DirectWrite is meant to be Uniscribe's replacement, and is needed for Windows Store apps if a system shaping API is to be used.
Add into the NMake Makefiles to build the DirectWrite shaping backend, but as PR harfbuzz#134 mentions, this is considered to be in an experimental state, so don't include this in the build by default for now. This is most probably going to replace the Uniscribe backend eventually, since DirectWrite is meant to be Uniscribe's replacement, and is needed for Windows Store apps if a system shaping API is to be used.
Add into the NMake Makefiles to build the DirectWrite shaping backend, but as PR harfbuzz#134 mentions, this is considered to be in an experimental state, so don't include this in the build by default for now. This is most probably going to replace the Uniscribe backend eventually, since DirectWrite is meant to be Uniscribe's replacement, and is needed for Windows Store apps if a system shaping API is to be used.
Add into the NMake Makefiles to build the DirectWrite shaping backend, but as PR harfbuzz#134 mentions, this is considered to be in an experimental state, so don't include this in the build by default for now. This is most probably going to replace the Uniscribe backend eventually, since DirectWrite is meant to be Uniscribe's replacement, and is needed for Windows Store apps if a system shaping API is to be used.
Add into the NMake Makefiles to build the DirectWrite shaping backend, but as PR harfbuzz#134 mentions, this is considered to be in an experimental state, so don't include this in the build by default for now. This is most probably going to replace the Uniscribe backend eventually, since DirectWrite is meant to be Uniscribe's replacement, and is needed for Windows Store apps if a system shaping API is to be used.
Add into the NMake Makefiles to build the DirectWrite shaping backend, but as PR harfbuzz#134 mentions, this is considered to be in an experimental state, so don't include this in the build by default for now. This is most probably going to replace the Uniscribe backend eventually, since DirectWrite is meant to be Uniscribe's replacement, and is needed for Windows Store apps if a system shaping API is to be used.
Add into the NMake Makefiles to build the DirectWrite shaping backend, but as PR harfbuzz#134 mentions, this is considered to be in an experimental state, so don't include this in the build by default for now. This is most probably going to replace the Uniscribe backend eventually, since DirectWrite is meant to be Uniscribe's replacement, and is needed for Windows Store apps if a system shaping API is to be used.
Add into the NMake Makefiles to build the DirectWrite shaping backend, but as PR harfbuzz#134 mentions, this is considered to be in an experimental state, so don't include this in the build by default for now. This is most probably going to replace the Uniscribe backend eventually, since DirectWrite is meant to be Uniscribe's replacement, and is needed for Windows Store apps if a system shaping API is to be used.
|
Hi, For references, I have it in a commit in PR #164 integration in the autotools build system, which I managed to do successfully with MSYS2/mingw-w64. With blessings! |
Update bundled harfbuzz to 2.3.1. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/134) <!-- Reviewable:end -->
More description on this mailing list post.