Skip to content

Get global font metrics from OS/2 table (fallback to hhea table) #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Get global font metrics from OS/2 table (fallback to hhea table) #165

wants to merge 2 commits into from

Conversation

simoncozens
Copy link
Collaborator

No description provided.

@simoncozens
Copy link
Collaborator Author

Wait! This isn't working!

@simoncozens
Copy link
Collaborator Author

I don't understand why not, but my function implementations (hb_ft_get_font_extents / hb_ot_get_font_extents) aren't being called. It just goes hb_font_get_extents -> hb_font_get_font_extents_parent -> hb_font_get_font_extents_nil. It certainly worked before the parent/nil split, but now it looks right to me and I can't find any other bits of code to cargo-cult.

@simoncozens
Copy link
Collaborator Author

OK, apologies for the git madness but I think I have something working now.

@simoncozens simoncozens mentioned this pull request Nov 6, 2015
Closed
@behdad
Copy link
Member

behdad commented Nov 7, 2015

Thanks. Sorry for the split. I didn't remember that you had an outstanding patch against those parts of the code.

@behdad behdad mentioned this pull request Nov 9, 2015
Closed
@behdad
Copy link
Member

behdad commented Nov 19, 2015

Hey, a release was way overdue, and I had to fix things before I could get a release out. Just managed to finish those (OOM handling, space shaping, etc), so got a release out, 1.1.0 even. The next item I have on my list is to integrate this work (after splitting it for horizontal and vertical metrics.) Thanks.

@ebraminio
Copy link
Collaborator

Perhaps this patch is worth to look, https://codereview.chromium.org/1450303002/

@behdad
Copy link
Member

behdad commented Nov 25, 2015

I'm almost done with this.

@behdad
Copy link
Member

behdad commented Nov 27, 2015

Simon,

Can you try this branch:
https://github.com/behdad/harfbuzz/tree/font-extents

@simoncozens
Copy link
Collaborator Author

This works for me with the new linespacing package in SILE. Thank you!

@behdad behdad closed this in e1d4d0f Dec 10, 2015
gpgreen pushed a commit to gpgreen/harfbuzz that referenced this pull request Jan 10, 2024
Auto merge of harfbuzz#165 - waywardmonkeys:update-to-harfbuzz-2.6.1,…
1c4782f 
… r=jdm

Update to harfbuzz 2.6.1.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/165)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simoncozens @behdad @ebraminio