fix typo in _hb_buffer_serialize_glyphs_text() #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'if (pos->y_advance)' result is always false. 'pos' is pointer to array of hb_glyph_position_t structures
|
Thanks. I fixed this manually. Note that your comment "'if (pos->y_advance)' result is always false." is incorrect. pos->y_advance is equivalent to pos[0].y_advance in C / C++. |
behdad
added a commit
that referenced
this pull request
Jan 23, 2014
jfkthame
pushed a commit
to jfkthame/harfbuzz
that referenced
this pull request
Apr 27, 2014
Closed
gpgreen
pushed a commit
to gpgreen/harfbuzz
that referenced
this pull request
Jan 10, 2024
Update to current rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'if (pos->y_advance)' result is always false. 'pos' is pointer to array of hb_glyph_position_t structures