Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Unicode 13.0.0 #2264

Merged
merged 4 commits into from May 15, 2020
Merged

Update to Unicode 13.0.0 #2264

merged 4 commits into from May 15, 2020

Conversation

dscorbett
Copy link
Collaborator

@dscorbett dscorbett force-pushed the unicode-13 branch 3 times, most recently from 932f135 to 28903f0 Compare March 16, 2020 14:54
@dscorbett dscorbett force-pushed the unicode-13 branch 2 times, most recently from 2bbfc66 to f344107 Compare March 22, 2020 22:46
@bobh0303
Copy link

Is accepting this PR what is needed to get the ball rolling on shaping for new chars in Unicode 13? If so, what needs to happen to move this forward?

@ebraminio
Copy link
Collaborator

Waiting for Behdad to comment then guessing will be very good to release afterward.

@bobh0303
Copy link

Assuming you mean @behdad .

@dscorbett dscorbett force-pushed the unicode-13 branch 2 times, most recently from 06837bb to f907643 Compare April 1, 2020 21:34
@behdad
Copy link
Member

behdad commented Apr 22, 2020

I used the current master branch of packTab except that I had to comment out lines 135 to 137 of init.py.

I still hope to review this work soon. But that condition is warning of something going wrong and should not be blindly ignored.

@dscorbett
Copy link
Collaborator Author

The problem is that packTab checks any(v < 0 for v in values) but v could be a string like '0x003Bu'. Changing it to any(not isinstance(v, str) and v < 0 for v in values) works around the problem. The generated hb-ucd-table.hh is unchanged.

@behdad
Copy link
Member

behdad commented Apr 22, 2020

I'll try to get to this soooon. Thanks.

@behdad behdad self-assigned this Apr 22, 2020
@LornaSIL
Copy link

@behdad Is there any chance this will get accepted soon? That would really be helpful.

@behdad behdad merged commit c151464 into master May 15, 2020
@behdad behdad deleted the unicode-13 branch May 15, 2020 02:12
@behdad
Copy link
Member

behdad commented May 15, 2020

The problem is that packTab checks any(v < 0 for v in values) but v could be a string like '0x003Bu'. Changing it to any(not isinstance(v, str) and v < 0 for v in values) works around the problem. The generated hb-ucd-table.hh is unchanged.

Thanks. That was unintended debugging leftover! Removed it.

In the future would be easier to review if you make multiple commits, one per change... eg:

  • [Unicode 13] Add new hb_script_t values
  • [Unicode 13] Update Arabic table
    ...

Thanks again!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants