Skip to content

Ucdn typo #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Ucdn typo #25

wants to merge 1 commit into from

Conversation

luisbg
Copy link
Contributor

@luisbg luisbg commented Feb 10, 2014

@behdad
Copy link
Member

behdad commented Feb 10, 2014

Thanks. Merged manually.

@behdad behdad closed this Feb 10, 2014
@luisbg
Copy link
Contributor Author

luisbg commented Feb 10, 2014

So prepping a PR from a patch doesn't help you? Just asking so I don't do it if it doesn't.

@behdad
Copy link
Member

behdad commented Feb 10, 2014

Yeah. I don't like the useless merge commits that github adds. So what I do is pull your tree and git cherry-pick. It helps that it's already in a commit, but for a one-liner like this, really, wasn't worth your time, I could do it right away when reading Werner's email. Thanks.

@luisbg
Copy link
Contributor Author

luisbg commented Feb 10, 2014

Cool! Just wanted to help.

By the way, these are also small quick commits, if you have the time:
#24

I know the rest will have to wait a bit :)

@lemzwerg
Copy link
Contributor

Thanks to both of you!

gpgreen pushed a commit to gpgreen/harfbuzz that referenced this pull request Jan 10, 2024
@SimonSapin
Merge pull request harfbuzz#25 from servo/rustdoc
ee4c20f 
Generate documentation with rustdoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisbg @behdad @lemzwerg