[meson] use the recommended way to store generated files #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebraminio
commented
Jul 3, 2020
ebraminio
force-pushed
the
meson-artifacts
branch
2 times, most recently
from
50a4f40
to
3b51a42
Compare
ebraminio
force-pushed
the
meson-artifacts
branch
from
f50634f
to
46e7956
Compare
ebraminio
added a commit
to ebraminio/harfbuzz
that referenced
this pull request
Jul 4, 2020
ebraminio
force-pushed
the
meson-artifacts
branch
from
46e7956
to
a28e3d7
Compare
ebraminio
changed the title
ebraminio
added a commit
to ebraminio/harfbuzz
that referenced
this pull request
Jul 4, 2020
ebraminio
force-pushed
the
meson-artifacts
branch
from
a28e3d7
to
6514f51
Compare
ebraminio
added a commit
to ebraminio/harfbuzz
that referenced
this pull request
Jul 4, 2020
ebraminio
force-pushed
the
meson-artifacts
branch
from
6514f51
to
c3d548c
Compare
ebraminio
force-pushed
the
meson-artifacts
branch
from
c3d548c
to
783fdea
Compare
ebraminio
commented
Jul 4, 2020
| @@ -4,9 +4,9 @@ | |||
|
|
|||
| os.chdir (os.environ.get ('srcdir', os.path.dirname (__file__))) | |||
|
|
|||
| HBHEADERS = os.environ.get ('HBHEADERS', '').split () or \ | |||
| HBHEADERS = [os.path.basename (x) for x in os.environ.get ('HBHEADERS', '').split ()] or \ | |||
There was a problem hiding this comment.
Why these are needed? File objects in meson (created using by files() in this patch) when turned to string are like src/hb-x.hh instead just the base name they used to, alternative approach would be top drop the above chdir yet I like to keep the script still runnable from command line that's why I am doing this for now.
ebraminio
commented
Jul 4, 2020
| foreach f : hb_sources | ||
| HBSOURCES += '@0@'.format(f) | ||
| endforeach | ||
| env.set('HBSOURCES', ' '.join(HBSOURCES)) |
There was a problem hiding this comment.
The for each above is to generate string out of files objects array, somehow a hack, I wish I could just pick the basename like the way it was before the patch at least so I didn't need to change check scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in mesonbuild/meson#7156 (comment)
Fixes #2530