Replace invalid codepoints with U+FFFD (REPLACEMENT CHARACTER) #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what Unicode suggests to do. In contrast to raising an error (which only useful when there is someone to catch that error), this allows to skip the codepoint validity checks in the hb_unicode callbacks.
KonstantinRitt
referenced
this pull request
Jul 11, 2014
behdad
added a commit
that referenced
this pull request
Jul 11, 2014
Only if the font doesn't support it. Ie, this gives the user to use non-Unicode codepoints as private values and return a meaningful glyph for them. But if it's invalid and font callback doesn't like it, and if font has U+FFFD, show that instead. Font functions that do not want this automatic replacement to happen should return true from get_glyph() if unicode > 0x10FFFF. Replaces #27
|
I fixed it this way instead: It's important to NOT lose the error. Here's how Pango prevents the automatic replacement and draw its own invalid-byte shape: |
gpgreen
pushed a commit
to gpgreen/harfbuzz
that referenced
this pull request
Jan 10, 2024
Add support for android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what Unicode suggests to do.
In contrast to raising an error (which only useful when there is
someone to catch that error), this allows to skip the codepoint
validity checks in the hb_unicode callbacks.