[dwrite] Use stream font loader instead GDI interop #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebraminio
force-pushed
the
master
branch
20 times, most recently
from
5972772 to
59c7f9d
Compare
ebraminio
changed the title
|
Also all the ifdefs are removed now as you wished so 😊. Despite the fact it now needs newer version of Win SDK in order to build but executable output works on older Windows versions also (I've tested it on Win 7) |
ebraminio
force-pushed
the
master
branch
4 times, most recently
from
7d78342 to
13c7c1c
Compare
This reduces memory consumption of my iterated font create/destroy cycle test significantly and makes it much better than uniscribe backend even
ebraminio
force-pushed
the
master
branch
5 times, most recently
from
e847899 to
d61b41a
Compare
No longer noticeable memory increase on create/destroy iterations, highly better than current state of uniscribe backend
Addressing Nikolay Sivov reviews on harfbuzz mailing list
|
Thanks Ebrahim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes DirectWrite backend to use dwrite font file stream API instead falling back to Uniscribe suited solution, and also improves the backend to not create dwrite font object each shape time which have led to a significant performance boost on my tests. As the result of these changes the incorporated tricks to create HFONT objects are no longer needed on this backend so most of GDI backend shared codes are also removed.
In case no review would be given, I think this is ready to merge.