hb-font: Fix a potentially undefined use of memcmp() #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it’s fine to call memcmp(x, 0, 0) in practice, the C99 standard explicitly says that this is not allowed: even if the length is zero, the pointer arguments must be valid. http://stackoverflow.com/a/16363034 Coverity ID: 141178 Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
Thanks. These quirks in the standards are really annoying. :) |
|
Humm. I have no idea why check-defs.sh is failing all in a sudden. |
See https://travis-ci.org/khaledhosny/harfbuzz/jobs/199785332#L1065 |
behdad
added a commit
that referenced
this pull request
Feb 8, 2017
Hopefully fixes Travis faliure? #413 (comment) https://travis-ci.org/khaledhosny/harfbuzz/jobs/199785332#L1065
Thanks. Let's see if I managed to fix it. |
|
This fixed the Linux build, the Mac build seems to be failing for a different reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it’s fine to call memcmp(x, 0, 0) in practice, the C99 standard
explicitly says that this is not allowed: even if the length is zero,
the pointer arguments must be valid.
http://stackoverflow.com/a/16363034
Coverity ID: 141178
Signed-off-by: Philip Withnall withnall@endlessm.com