Clarify the last step of release #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Done. :) BTW, I don't need to create a release. After I push the tag, I just go edit the tag and upload binaries. |
|
Oh, so please fix it. Thanks On a separate issue, https://github.com/behdad/harfbuzz/blob/master/harfbuzz.doap#L16 is referring to freedesktop, I am not sure how the whole thing is still relevant but maybe needs to be updated with current status of the project. |
behdad
added a commit
that referenced
this pull request
Oct 23, 2017
marklh9
added a commit
to marklh9/harfbuzz
that referenced
this pull request
Nov 17, 2017
This patch would fix incorrect glyph position highlighted in https://imgur.com/a/I0jJU as well as in harfbuzz#485. I try to explain my point of view and would like to know if I'm correct. Note: for harfbuzz I have do some cairo translate. In LibreOffice I don't. I don't know why. Original issue is to fix text offset issue of vertical writing in LibreOffice after LibreOffice update its HarfBuzz from 1.3.3 to 1.4.8. I tried to figure out how to use those values emprically. Y_offset was 0 with HarfBuzz 1.3.3 and has become -1160 (roughly 1EM upward) after upgrade to 1.4.8, I suspect that the offsets returned by Harfbuzz are always repect to h_origin: subtract_glyph_v_origin() -> get_glyph_v_origin_with_fallback -> guess_v_origin_minus_h_origin But underlying renderer might expect positions relative to the vertical origin. To compensate the result I try to translate them back by calling hb_font_add_glyph_origin_for_direction(), to add the horizontal origin, hence make offset relative to the v origin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.