Skip to content

Conversation

ebraminio
Copy link
Collaborator

Part of #589

@behdad, you should login into http://circleci.com and enable it for harfbuzz but before that, do you have any idea why this is happening on some compilers? Have a look at this for more info.

[31/41] Building CXX object CMakeFiles/harfbuzz.dir/src/hb-ot-font.cc.o
FAILED: CMakeFiles/harfbuzz.dir/src/hb-ot-font.cc.o 
/usr/arm-linux-androideabi/bin/arm-linux-androideabi-g++ --sysroot=/usr/arm-linux-androideabi/sysroot  -DHAVE_FALLBACK -DHAVE_INTEL_ATOMIC_PRIMITIVES -DHAVE_OT -DHAVE_UCDN -I../src -Isrc -I../src/hb-ucdn  -MD -MT CMakeFiles/harfbuzz.dir/src/hb-ot-font.cc.o -MF CMakeFiles/harfbuzz.dir/src/hb-ot-font.cc.o.d -o CMakeFiles/harfbuzz.dir/src/hb-ot-font.cc.o -c ../src/hb-ot-font.cc
In file included from ../src/hb-ot-post-table.hh:31:0,
                 from ../src/hb-ot-font.cc:41:
../src/hb-sort-r.hh: In function 'void hb_sort_r(void*, size_t, size_t, int (*)(const void*, const void*, void*), void*)':
../src/hb-sort-r.hh:247:46: error: 'qsort_r' was not declared in this scope
         qsort_r(base, nel, width, compar, arg);
                                              ^

@behdad
Copy link
Member

behdad commented Oct 31, 2017

Yes, I commented the prototype for qsort_r so as not to duplicate it. Let me define _GNU_SOURCE.

behdad added a commit that referenced this pull request Oct 31, 2017
Might help with #592
Ie. bringing in qsort_r() prototype always.
@ebraminio
Copy link
Collaborator Author

Please make sure it will work on Visual C also https://ci.appveyor.com/project/behdad/harfbuzz/build/1.0.701/job/yeg17r37a9ledfv4#L473

@behdad
Copy link
Member

behdad commented Oct 31, 2017

Enabled.

@behdad
Copy link
Member

behdad commented Oct 31, 2017

If qsort_r becomes too much trouble, I'll remove that and just use the included version. Maybe we should do that anyway.

@ebraminio
Copy link
Collaborator Author

ebraminio commented Oct 31, 2017

Rebased and still https://circleci.com/gh/ebraminio/harfbuzz/tree/master

FAILED: CMakeFiles/harfbuzz.dir/src/hb-ot-font.cc.o 
/usr/arm-linux-androideabi/bin/arm-linux-androideabi-g++ --sysroot=/usr/arm-linux-androideabi/sysroot  -DHAVE_FALLBACK -DHAVE_INTEL_ATOMIC_PRIMITIVES -DHAVE_OT -DHAVE_UCDN -I../src -Isrc -I../src/hb-ucdn  -MD -MT CMakeFiles/harfbuzz.dir/src/hb-ot-font.cc.o -MF CMakeFiles/harfbuzz.dir/src/hb-ot-font.cc.o.d -o CMakeFiles/harfbuzz.dir/src/hb-ot-font.cc.o -c ../src/hb-ot-font.cc
In file included from ../src/hb-ot-post-table.hh:31:0,
                 from ../src/hb-ot-font.cc:41:
../src/hb-sort-r.hh: In function 'void hb_sort_r(void*, size_t, size_t, int (*)(const void*, const void*, void*), void*)':
../src/hb-sort-r.hh:247:46: error: 'qsort_r' was not declared in this scope
         qsort_r(base, nel, width, compar, arg);
                                              ^

@ebraminio
Copy link
Collaborator Author

Added our new badge also :) I don't know why we don't see it yet

@ebraminio ebraminio changed the title [ci] Add cross-compiling CI config based circleci and dockcross [ci] Add CircleCI for cross-compiling Oct 31, 2017
@ebraminio ebraminio merged commit b7982c9 into harfbuzz:master Oct 31, 2017
@ebraminio
Copy link
Collaborator Author

@behdad, I guess yiu should start the ci or something like that as the badge on readme.

@behdad
Copy link
Member

behdad commented Oct 31, 2017

Ok I'll get rid of the qsort_r.

@behdad
Copy link
Member

behdad commented Oct 31, 2017

In the queue.

@ebraminio
Copy link
Collaborator Author

One intresting thing to note, circleci provides SSH access to Ci machines, you can use it when you want access the environment harfbuzz build fails.

@ebraminio
Copy link
Collaborator Author

Also I should note we are not limited to crossdock images, you can find and even create and host freely on dockerhub your own images for testing more environments.

@ebraminio
Copy link
Collaborator Author

Also feel free to change cmake build of this ci config to autotools, I just found using cmake easier. I didn't test auxilary harfbuzz thinga like hb-ft as they need separate compile of other libraries also but feel free to do so if you found easier way.

@behdad
Copy link
Member

behdad commented Oct 31, 2017

I don't care about cmake or not, but do care about running tests if possible. Though, just building is indeed better than nothing. Thanks. Oh wait, these are all cross-builds, so we cannot test, right? Then cmake is as good as any. Thanks!

@behdad
Copy link
Member

behdad commented Oct 31, 2017

Any idea why arm64 is failing:

Error response from daemon: repository dockcross/android-arm64 not found: does not exist or no pull access

Also, can you somehow configure it to not try building gh-pages branch?

@ebraminio
Copy link
Collaborator Author

Also, can you somehow configure it to not try building gh-pages branch?

https://circleci.com/docs/2.0/configuration-reference/#branches

branches:
  ignore:
    - gh-pages

would do that I guess.

@behdad
Copy link
Member

behdad commented Nov 1, 2017

Thanks.

behdad added a commit that referenced this pull request Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants