Categorize U+20F0 COMBINING ASTERISK ABOVE for use in Grantha #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about the dash and caret marks that also appear in L2/09-372 samples -- should something similar be done about those? |
|
Hmm, I see there are U+A8FA and U+A8FB in the Devanagari Extended block, but I don't know enough about them to judge whether these are the same characters as seen in the Grantha examples, or behave differently in some way. |
|
That document specifies that they are U+1CD0 VEDIC TONE KARSHANA and U+1CD2 VEDIC TONE PRENKHA. |
|
Ah, right - I forgot about those, sorry! |
|
Waiting for @jfkthame to advise how to fix this. |
|
Given this seems to be a valid use case, @dscorbett's fix seems reasonable to me; I think we can just merge it. |
|
Thanks David. Can you please update the patch to insert URL to this PR in the code as well? |
behdad
reviewed
Nov 14, 2017
src/gen-use-table.py
Outdated
| @@ -303,6 +304,9 @@ def map_to_use(data): | |||
| # TODO: https://github.com/behdad/harfbuzz/issues/525 | |||
| if U == 0x1A7F: UISC = Consonant_Final; UIPC = Bottom | |||
|
|
|||
| # TODO: Neither in Unicode 10.0 nor in USE's override list | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
U+20F0 COMBINING ASTERISK ABOVE can be used as a svara marker in Grantha, but since Unicode does not define its Indic categories, a dotted circle is inserted between it and a following svara marker. For example, the string ⟨𑌊⃰𑍧𑍧⟩ from L2/09-372 gets a dotted circle.