[coretext] Add hb_coretext_font_create() #629
Conversation
| if (unlikely (hb_object_is_inert (font))) | ||
| return font; | ||
|
|
||
| /* Let there be dragons here... */ |
There was a problem hiding this comment.
Normally that value (ctfont) is automatically created on-demand by HarfBuzz generic layer. We are sneaking in and setting it here. It works and is correct, but is fragile if the rest of the code changes....
|
@ebraminio since when we started -Werror'ing? So, Mac build has been broken since, because of the deprecation warnings? |
|
Ok I see I'm the one who added that... |
|
Can we add -Wno-deprecated-declarations to OS X builds? |
Does having access to a macOS terminal help you perhaps to try that or #486? If so, I guess CircleCI provides macOS machines with SSH access. |
Seems like I fixed it. ssh to mac would be nice if it works. But if it's too much work to figure out every time I needed every six months, easier to just sit next to drott physically somewhere in the world and do it together. |
|
Turned out CircleCI's macOS support needs some fee unlike TravisCI :( |
behdad
force-pushed
the
ctfont
branch
5 times, most recently
from
5bb73e7 to
2efa1ef
Compare
Fixes #628 New API: hb_coretext_font_create()
Uncompiled, untested.
Fixes #628
New API:
hb_coretext_font_create()