[cmake] Colorize output when using cmake + ninja.#674
Merged
Conversation
Collaborator
|
I guess it should be applied to CMAKE_C_FLAGS as we use it for some of units, and can this applied to upstream's cmake ninja generator also do you believe? Btw, can you give us a hand on #675? I've put the command can be used for compilation, the issue is harfbuzz's cmake exporting unnecessary symbols and some static initializing things that tests that currently working fine with the output of autotools are catching them. |
Collaborator
|
Tried to resolve the conflict and add CMAKE_C_FLAGS but seem to broke it somehow? |
waywardmonkeys
force-pushed
the
color-output-with-ninja
branch
from
4f88fdc to
8b94100
Compare
Contributor
Author
|
I've gone ahead and rebased this forward, added setting the C compiler flags as well and force pushed it here. |
Collaborator
|
Great, as a bikeshedding, please put the new part before |
Due to how ninja runs clang and gcc, it doesn't colorize the output like make does. This forces color output in this situation.
waywardmonkeys
force-pushed
the
color-output-with-ninja
branch
from
8b94100 to
4d39274
Compare
Contributor
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to how ninja runs clang and gcc, it doesn't colorize the output
like make does. This forces color output in this situation.