Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Colorize output when using cmake + ninja. #674

Merged
merged 1 commit into from Jan 4, 2018

Conversation

@waywardmonkeys
Copy link
Contributor

@waywardmonkeys waywardmonkeys commented Jan 3, 2018

Due to how ninja runs clang and gcc, it doesn't colorize the output
like make does. This forces color output in this situation.

@ebraminio
Copy link
Collaborator

@ebraminio ebraminio commented Jan 4, 2018

I guess it should be applied to CMAKE_C_FLAGS as we use it for some of units, and can this applied to upstream's cmake ninja generator also do you believe?

Btw, can you give us a hand on #675? I've put the command can be used for compilation, the issue is harfbuzz's cmake exporting unnecessary symbols and some static initializing things that tests that currently working fine with the output of autotools are catching them.

@ebraminio
Copy link
Collaborator

@ebraminio ebraminio commented Jan 4, 2018

Tried to resolve the conflict and add CMAKE_C_FLAGS but seem to broke it somehow?

@waywardmonkeys waywardmonkeys force-pushed the waywardmonkeys:color-output-with-ninja branch from 4f88fdc to 8b94100 Jan 4, 2018
@waywardmonkeys
Copy link
Contributor Author

@waywardmonkeys waywardmonkeys commented Jan 4, 2018

I've gone ahead and rebased this forward, added setting the C compiler flags as well and force pushed it here.

@ebraminio
Copy link
Collaborator

@ebraminio ebraminio commented Jan 4, 2018

Great, as a bikeshedding, please put the new part before # Test :)

Due to how ninja runs clang and gcc, it doesn't colorize the output
like make does. This forces color output in this situation.
@waywardmonkeys waywardmonkeys force-pushed the waywardmonkeys:color-output-with-ninja branch from 8b94100 to 4d39274 Jan 4, 2018
@waywardmonkeys
Copy link
Contributor Author

@waywardmonkeys waywardmonkeys commented Jan 4, 2018

Done.

@ebraminio ebraminio merged commit 4f80078 into harfbuzz:master Jan 4, 2018
16 checks passed
16 checks passed
ci/circleci: alpine Your tests passed on CircleCI!
Details
ci/circleci: android-arm Your tests passed on CircleCI!
Details
ci/circleci: archlinux Your tests passed on CircleCI!
Details
ci/circleci: base Your tests passed on CircleCI!
Details
ci/circleci: browser-asmjs Your tests passed on CircleCI!
Details
ci/circleci: distcheck Your tests passed on CircleCI!
Details
ci/circleci: dos Your tests passed on CircleCI!
Details
ci/circleci: fedora-out-of-tree Your tests passed on CircleCI!
Details
ci/circleci: freebsd9 Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: linux-mips Your tests passed on CircleCI!
Details
ci/circleci: oracledeveloperstudio Your tests passed on CircleCI!
Details
ci/circleci: psvita Your tests passed on CircleCI!
Details
ci/circleci: windows-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@waywardmonkeys waywardmonkeys deleted the waywardmonkeys:color-output-with-ninja branch Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.