New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomics: Favor compiler primitives over macOS APIs. #676

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Projects
None yet
2 participants
@waywardmonkeys
Contributor

waywardmonkeys commented Jan 4, 2018

In macOS 10.12, the OSMemoryBarrier and related APIs were deprecated
in favor of using std::atomic. On the way to supporting std::atomic,
we can favor using the "Intel primitives" which are also available on
macOS.

atomics: Favor compiler primitives over macOS APIs.
In macOS 10.12, the `OSMemoryBarrier` and related APIs were deprecated
in favor of using `std::atomic`. On the way to supporting `std::atomic`,
we can favor using the "Intel primitives" which are also available on
macOS.
@ebraminio

This comment has been minimized.

Show comment
Hide comment
@ebraminio

ebraminio Jan 4, 2018

Member

This is a good idea I believe, I went for std::atomic on #486 and not much success but feel free to try that also.

Member

ebraminio commented Jan 4, 2018

This is a good idea I believe, I went for std::atomic on #486 and not much success but feel free to try that also.

@waywardmonkeys

This comment has been minimized.

Show comment
Hide comment
@waywardmonkeys

waywardmonkeys Jan 4, 2018

Contributor

I was looking at using std::atomic as well ... but figured this was a much nicer first step and solves the immediate issue without all of the other pain that you saw in #486.

Contributor

waywardmonkeys commented Jan 4, 2018

I was looking at using std::atomic as well ... but figured this was a much nicer first step and solves the immediate issue without all of the other pain that you saw in #486.

@ebraminio ebraminio merged commit 8a0952d into harfbuzz:master Jan 4, 2018

16 checks passed

ci/circleci: alpine Your tests passed on CircleCI!
Details
ci/circleci: android-arm Your tests passed on CircleCI!
Details
ci/circleci: archlinux Your tests passed on CircleCI!
Details
ci/circleci: base Your tests passed on CircleCI!
Details
ci/circleci: browser-asmjs Your tests passed on CircleCI!
Details
ci/circleci: distdir Your tests passed on CircleCI!
Details
ci/circleci: dos Your tests passed on CircleCI!
Details
ci/circleci: fedora-out-of-tree Your tests passed on CircleCI!
Details
ci/circleci: freebsd9 Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: linux-mips Your tests passed on CircleCI!
Details
ci/circleci: oracledeveloperstudio Your tests passed on CircleCI!
Details
ci/circleci: psvita Your tests passed on CircleCI!
Details
ci/circleci: windows-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ebraminio

This comment has been minimized.

Show comment
Hide comment
@ebraminio

ebraminio Jan 4, 2018

Member

Went ahead and merged this, without in detail knowing pros of cons of the approach, as our main clients on macOS at leasts, Chrome and Firefox, are using harfbuzz without these and this was just giving the developers on macOS compile headache. Of course I don't know much about build configuration of Qt and GTK, I don't believe that would hurt much as updates like this https://www.theregister.co.uk/2018/01/02/intel_cpu_design_flaw/ going to :)

Member

ebraminio commented Jan 4, 2018

Went ahead and merged this, without in detail knowing pros of cons of the approach, as our main clients on macOS at leasts, Chrome and Firefox, are using harfbuzz without these and this was just giving the developers on macOS compile headache. Of course I don't know much about build configuration of Qt and GTK, I don't believe that would hurt much as updates like this https://www.theregister.co.uk/2018/01/02/intel_cpu_design_flaw/ going to :)

@waywardmonkeys waywardmonkeys deleted the waywardmonkeys:favor-atomic-primitives branch Jan 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment