Skip to content

BASE table #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 27, 2018
Merged

BASE table #838

merged 15 commits into from
Feb 27, 2018

Conversation

behdad
Copy link
Member

@behdad behdad commented Feb 26, 2018

No description provided.

@behdad behdad mentioned this pull request Feb 26, 2018
@ebraminio
Copy link
Collaborator

ebraminio commented Feb 26, 2018

Build issues got fixed

@ebraminio
Copy link
Collaborator

Of course whether hb_ot_base_has_data API is needed is another question.

@behdad
Copy link
Member Author

behdad commented Feb 26, 2018

Thanks. :)

@ebraminio
Copy link
Collaborator

ebraminio commented Feb 26, 2018

What APIs (or any) do you imagine for this Behdad?

@ebraminio
Copy link
Collaborator

ebraminio commented Feb 26, 2018

Or, sorry [again] for rush you on this. I wanted to see if I can do some more help.

@behdad
Copy link
Member Author

behdad commented Feb 26, 2018

What APIs (or any) do you imagine for this Behdad?

Have to think about it. Let's remove the has_info() API and merge this; figure out API later.

@eroux
Copy link
Contributor

eroux commented Feb 27, 2018

Oh, thanks a lot for merging that, that comes as a very pleasant surprise!

@behdad
Copy link
Member Author

behdad commented Feb 27, 2018

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants