Support CPAL table #841
Support CPAL table #841
Conversation
The name id 0 is used as Copyright notice. It's quite unlikely that a font supplies a color palette with the exact same name as the font's copyright notice, but the API should not prevent this. Also, try to fix a problem with GObject introspection, where the auto-generated Python bindings could not return palette colors.
ebraminio
force-pushed
the
color
branch
4 times, most recently
from
72e726d to
991b716
Compare
src/hb-ot-cpal-table.hh
Outdated
| if (paletteFlags.is_null ()) | ||
| return HB_OT_COLOR_PALETTE_FLAG_DEFAULT; | ||
|
|
||
| const HBUINT32* flags = (const HBUINT32 *) (const void*) &paletteFlags (base); |
There was a problem hiding this comment.
I wish I could use UnsizedArrayOf... not sure if this is correct
There was a problem hiding this comment.
Yeah, will move UnsizedArrayOf to hb-open-type.hh some time.
|
Ok let me finish the other stuff. If this is clean and adds no API for now, feel free to merge. |
ebraminio
force-pushed
the
color
branch
2 times, most recently
from
d675cd0 to
c7aac87
Compare
|
I improved it as far as I could from the things learned from the previous experiences, like sanitizing the arrays, bringing the logic on the right place and making data private, however in the process, I was careful about not breaking the tests so hopefully it won't give you headache when you want use the API or not before disabling the tests altogether. However I didn't refactor I think Wine implementation is a good place to be inspired about what would be needed for a real implementation to be exposed, https://github.com/wine-mirror/wine/blob/5ec6b8f807f61ee77b9a96d94798c8e3f3db7af4/dlls/dwrite/dwrite_private.h#L220-L238 (and other related places on the repo) |
|
Thanks. Let me finish BASE (while also keeping eye on subsetter, and redoing fonttools table packing) and aat, then review this. |
ebraminio
force-pushed
the
color
branch
7 times, most recently
from
cdc16e2 to
4490d62
Compare
|
Ok, this adds no API now (except the some enums and structs which I guess are not issue) and is clean (as far as I could, and to idea is to learn from your touch ups :) ), so lets have it as your previous suggestion. |
In continuation to and closes #244, addressed some of the review there and (unsure about if
hb_ot_color_get_palette_colorsis best API we can provide?) however the related test fails. I want to see if my changes are in right direction? (making fields private, doing checks at the related places, ...)