[colr] Implement #847
Merged
[colr] Implement #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The API needs to be redone. That adds more work before I can get next release out... Typically we haven't done this. But I'm fine as a one-time thing. |
|
Opened #849 for discussing that, no problem, just before making a release please make sure I haven't exposed anything harmful, AFAIK there are some enum and structs that was used by the table also, they obviously are not part of ABI but it is possible "ABI Tracker" would complain about them if removed someday (as a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have CPAL table, lets have COLR also, hopefully we can reach to both and providing things like tests, public API and such on the next release. I like to port my color emoji code to it https://github.com/ebraminio/glcourse/blob/master/emojidump.cc someday on that process hopefully I can test and make sure everything works as intended also and add subsetted fonts.